From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59351: 29.0.50; [PATCH] Fix mouse click position to menu bar entry Date: Fri, 18 Nov 2022 20:45:03 +0200 Message-ID: <83iljc9k5s.fsf@gnu.org> References: <87tu2wlku7.fsf@elite.giraud> <878rk8ee6d.fsf@yahoo.com> <8735agr0g4.fsf@elite.giraud> <83o7t4bhk4.fsf@gnu.org> <87zgcov1ps.fsf@elite.giraud> <8335agbai5.fsf@gnu.org> <875yfcuw5r.fsf@elite.giraud> <83r0y09td6.fsf@gnu.org> <87zgcotbw9.fsf@elite.giraud> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15479"; mail-complaints-to="usenet@ciao.gmane.io" Cc: luangruo@yahoo.com, 59351@debbugs.gnu.org To: Manuel Giraud Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 18 19:46:22 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ow6Na-0003oG-HL for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 18 Nov 2022 19:46:22 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ow6NK-00077I-6r; Fri, 18 Nov 2022 13:46:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow6NG-00076d-EO for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 13:46:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1ow6NG-0003RQ-2x for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 13:46:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ow6NF-00042H-Sz for bug-gnu-emacs@gnu.org; Fri, 18 Nov 2022 13:46:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 18 Nov 2022 18:46:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59351 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 59351-submit@debbugs.gnu.org id=B59351.166879710915450 (code B ref 59351); Fri, 18 Nov 2022 18:46:01 +0000 Original-Received: (at 59351) by debbugs.gnu.org; 18 Nov 2022 18:45:09 +0000 Original-Received: from localhost ([127.0.0.1]:38242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow6MO-000418-Ky for submit@debbugs.gnu.org; Fri, 18 Nov 2022 13:45:08 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41472) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1ow6MN-00040t-2S for 59351@debbugs.gnu.org; Fri, 18 Nov 2022 13:45:07 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow6MH-00039M-2O; Fri, 18 Nov 2022 13:45:01 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=847f5yAYXP58ch5PC1j6JYLMlcX/ZEnbY+iXaZzTtM8=; b=m714ixoLKTJR TdWFSZBsHlA9GRrOCCtgWsKXutW1oQC++VNaiG//9AmcxFpwhs4RbkrOPG5UMBnpvYYMiMYkPZY+S NvYtI1qnz45Lshh54lrUUoK6a5H0xIZRfGcvUuFidwQBHcFrdo45QsXdRI2MAhuIkjuL/dYZNaI+y a4xjYTjt/NKAflT3TOys/NxdzHo8lVEmqvzJA6Vv5Bu4xW47ZPHpGejdT4lrz2Ws1XsNT2hM1QgMK h2h10gzu3kjy7tSzHu7WWyC7dhMK7qLwA30K0eNvMVWwrszD7Y6gTh8l+wq/X1err98PLP0WqMjUz mwR3A8PxmkJtHCZzH/NlTg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1ow6MF-0002AB-Rq; Fri, 18 Nov 2022 13:45:00 -0500 In-Reply-To: <87zgcotbw9.fsf@elite.giraud> (message from Manuel Giraud on Fri, 18 Nov 2022 18:23:18 +0100) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:248268 Archived-At: > From: Manuel Giraud > Cc: luangruo@yahoo.com, 59351@debbugs.gnu.org > Date: Fri, 18 Nov 2022 18:23:18 +0100 > > Eli Zaretskii writes: > > > I thought you said XWINDOW (f->menu_bar_window) doesn't compile in the > > "--without-x" build? I think you need the HAVE_WINDOW_SYSTEM > > condition as well. > > This new one does compile "--without-x". LGTM, thanks. > About the height of the menu bar, you were right. I've tested and > display_menu_bar is called quite often and is called after a > (set-face-font 'menu "Iosevka-18"). So maybe it is the last call to > compute_line_metrics that does not do the required job. I suggest to step through the code there and see why that happens. Feel free to describe what you see if the reason is not obvious.