From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#58877: 29.0.50; [PATCH] When killing Emacs from a client frame with no other frames, Emacs shows a useless error prompt Date: Sat, 26 Nov 2022 16:43:57 +0200 Message-ID: <83ilj1srma.fsf@gnu.org> References: <8121efd5-77c3-0682-ce0f-6be9375dadd8@gmail.com> <83a65dhm7f.fsf@gnu.org> <13835614-c593-ba2d-5373-a9950f6f3dab@gmail.com> <83k03kwoy6.fsf@gnu.org> <83a64fupwv.fsf@gnu.org> <83wn7iu6rz.fsf@gnu.org> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="25191"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 58877@debbugs.gnu.org To: Jim Porter Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 26 15:44:10 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oywPa-0006Q5-GC for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 26 Nov 2022 15:44:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1oywPT-0007gl-Qs; Sat, 26 Nov 2022 09:44:03 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oywPS-0007gV-VI for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 09:44:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1oywPS-0006lO-ND for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 09:44:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1oywPS-0005bd-Cb for bug-gnu-emacs@gnu.org; Sat, 26 Nov 2022 09:44:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 26 Nov 2022 14:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 58877 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 58877-submit@debbugs.gnu.org id=B58877.166947382121511 (code B ref 58877); Sat, 26 Nov 2022 14:44:02 +0000 Original-Received: (at 58877) by debbugs.gnu.org; 26 Nov 2022 14:43:41 +0000 Original-Received: from localhost ([127.0.0.1]:38345 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oywP6-0005at-MZ for submit@debbugs.gnu.org; Sat, 26 Nov 2022 09:43:40 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:50126) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1oywP4-0005ag-Fl for 58877@debbugs.gnu.org; Sat, 26 Nov 2022 09:43:39 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oywOz-0006ez-5G; Sat, 26 Nov 2022 09:43:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=NNHmu2qZTBzFQkgz04mHjlWtmpVbFOw4GAbxtY/ifHU=; b=kFqNPhHuVuwK J7be9OJjXgZ3RNxK+Z68e+CaTawYFozKrhNNC6KxoxzbtwS/sb1mJt6tkCO/HN/sRd82+boRky6zx IF0vTm1qtCEO8Pg8SWoWUfvqjrIPGW8mt5mgU3N3eyV6zm2b7D4xfGIf0Z3odKCd/xoiabd63ylo1 sMeXamFX49eI2AhZyiCc2knD68YzP5G5qwYv9aMpSbu1nuthIuOrrH+XxCYwxcq/U3SLcoSviptVz Y+sjBAAlu4h7JqCAWzqpTR33fXwLCYCdueRPlK3w27Xvw9LEh8TknjsrjtOzGcgm9UEWaYasOa8TI HAxvQ4Yyu9HUo8/XlaZdUg==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1oywOy-00039K-LO; Sat, 26 Nov 2022 09:43:32 -0500 In-Reply-To: (message from Jim Porter on Fri, 25 Nov 2022 12:57:37 -0800) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:249100 Archived-At: > Date: Fri, 25 Nov 2022 12:57:37 -0800 > Cc: 58877@debbugs.gnu.org > From: Jim Porter > > >> Hm, it looks like the emacsclient may not be starting up correctly. > >> Could you try the attached patch? I doubt this will fix the tests, but > >> hopefully you'll get some more-useful error messages. > > > > Here are the failure info from each failed test after this patch: > > > > Test server-tests/emacsclient/create-frame condition: > > Output: > > (ert-test-failed "timed out waiting for (or (= (length server-clients) (1+ starting-client-count)) (eq (process-status emacsclient) exit-status)) to be non-nil") > > FAILED 1/7 server-tests/emacsclient/create-frame (5.062500 sec) at lisp/server-tests.el:138 > > Oops, sorry about that. I didn't realize until now that 'ert-info' > computes its message immediately, rather than at the time of printing > the info.[1] I've added a bit of code to ert.el to support this case, > which will hopefully produce better output. Never mind, I think I know what's the cause of the problem: I have my production session of Emacs running on the system ,and it already has the server started. So a plain call to server-start fails. I think you need to modify the tests to ensure the server file is created in a temporary directory. And keep in mind that the variable which affects that is different depending on whether server-use-tcp is or isn't non-nil.