all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Yuan Fu <casouri@gmail.com>, Stefan Monnier <monnier@iro.umontreal.ca>
Cc: dev@rjt.dev, aqua0210@foxmail.com, 59498@debbugs.gnu.org,
	mardani29@yahoo.es
Subject: bug#59498: 29.0.50; c++-ts-mode get wrong-type-argument error when enabled
Date: Sun, 27 Nov 2022 08:24:21 +0200	[thread overview]
Message-ID: <83ilj0rk2y.fsf@gnu.org> (raw)
In-Reply-To: <5ADA88E0-A105-47B5-B590-2591253781C1@gmail.com> (message from Yuan Fu on Sat, 26 Nov 2022 14:11:48 -0800)

> From: Yuan Fu <casouri@gmail.com>
> Date: Sat, 26 Nov 2022 14:11:48 -0800
> Cc: Randy Taylor <dev@rjt.dev>,
>  aqua0210@foxmail.com,
>  59498@debbugs.gnu.org,
>  mardani29@yahoo.es
> 
> >> +  (setq-local treesit-comment-start (rx "/" (or (+ "/") (+ "*"))))
> >> +  (setq-local treesit-comment-end (rx (+ (or "*")) "/"))
> >> 
> >>   (treesit-parser-create 'cpp)
> > 
> > Thanks, but this doesn't look right to me: why should c++-ts-mode set
> > variables for treesit.el?  It is more likely that treesit.el should use the
> > buffer-local values of comment-start and comment-end instead, and fall back
> > on generic values (if they make sense) only if the local values are not set.
> > 
> > Yuan, WDYT?
> 
> I added treesit-comment-start/end to help indenting comments. So this is the correct way to use them. The following comment explains why I created new variables:
> 
> ;; `comment-start' and `comment-end' assume there is only one type of
> ;; comment, and that the comment spans only one line.  So they are not
> ;; sufficient for our purpose.

??? This is surprisingly unclean, IMO.  For starters, the names of the
variables are confusing.  The need to define two sets of comment-start and
comment-end regexps is also a nuisance and a source of errors.

How do non-treesit modes handle this issue?  Why do the treesit-based modes
need something special here?

Stefan, any ideas?





  reply	other threads:[~2022-11-27  6:24 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-23  2:24 bug#59498: 29.0.50; c++-ts-mode get wrong-type-argument error when enabled Eason Huang
2022-11-23  8:44 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-23 10:53   ` Eason Huang
2022-11-24 14:39     ` Randy Taylor
2022-11-25 12:56       ` Eason Huang
2022-11-26 11:18       ` Eli Zaretskii
2022-11-26 22:11         ` Yuan Fu
2022-11-27  6:24           ` Eli Zaretskii [this message]
2022-11-27  7:18             ` Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors
2022-11-27  7:24               ` Eli Zaretskii
2022-11-27 22:21                 ` Yuan Fu
2022-11-28  0:24                   ` Stefan Kangas
2022-12-18  9:57                     ` Eli Zaretskii
2022-12-18 22:49                       ` Yuan Fu
2022-12-19 13:51                         ` Eli Zaretskii
2022-12-20  1:56                           ` Yuan Fu
2022-12-20 15:18                             ` Eli Zaretskii
2022-12-21  0:37                               ` Yuan Fu
2022-11-28 13:59                   ` Eason Huang
2022-11-27 22:00               ` Yuan Fu
     [not found] <m24juq9zn6.fsf@foxmail.com>
2022-11-30 21:33 ` Yuan Fu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ilj0rk2y.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=59498@debbugs.gnu.org \
    --cc=aqua0210@foxmail.com \
    --cc=casouri@gmail.com \
    --cc=dev@rjt.dev \
    --cc=mardani29@yahoo.es \
    --cc=monnier@iro.umontreal.ca \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.