From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] * lib-src/etags.c: Free variables. Date: Fri, 09 Dec 2022 17:30:42 +0200 Message-ID: <83ilikzja5.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="35128"; mail-complaints-to="usenet@ciao.gmane.io" Cc: emacs-devel@gnu.org To: lu4nx Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Fri Dec 09 16:31:18 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p3fLJ-0008wW-Lr for ged-emacs-devel@m.gmane-mx.org; Fri, 09 Dec 2022 16:31:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p3fL6-0007J0-I8; Fri, 09 Dec 2022 10:31:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3fKt-0007Eu-AU for emacs-devel@gnu.org; Fri, 09 Dec 2022 10:30:52 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3fKr-0001ZL-MT; Fri, 09 Dec 2022 10:30:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=LQufyCNxHkAsmwlmr+jGnZnO4wgkVmdvKPi2TqXMz8g=; b=bkBm5LSl1Scn wWhckd8ZA/RGDEAk6EqKGRfM2Yld7LHP8wwABpwRpZUJKHqscDfTC+5Y+Sw8/Hy9QQNxmT4ttCN2U qC+XCJKC08wA24ybWyuHEnvNOInTbl8ZkNzrii088tYwiqy7oiVEsbjl8aWEYqmq5U/p3+DbPUNGx N0gyW9wwbj65D68d5ynAClOuWhvjw0oaj6RiQBVbYJDk6Vq4wVMpPm1RdOi9/P4cUPkY+TQYDYpc8 yszgIXhv1VWMalLDwW0Exqn7djvOCNH9/YE3f9OcwOgSM2y7AwC05HWGtzXJGnojmYIgvZpR3SEWS lK9IsvnVRDwcLNgHq7XMUQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p3fKq-0006iL-So; Fri, 09 Dec 2022 10:30:49 -0500 In-Reply-To: (message from lu4nx on Fri, 9 Dec 2022 23:03:04 +0800) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:301075 Archived-At: > From: lu4nx > Cc: lu4nx > Date: Fri, 9 Dec 2022 23:03:04 +0800 > > --- > lib-src/etags.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/lib-src/etags.c b/lib-src/etags.c > index a06c236140..0822882d46 100644 > --- a/lib-src/etags.c > +++ b/lib-src/etags.c > @@ -1339,6 +1339,8 @@ main (int argc, char **argv) > "AND read file names from it"); > while (readline_internal (&filename_lb, stdin, "-", false) > 0) > process_file_name (filename_lb.buffer, lang); > + > + free (filename_lb.buffer); > } > else > process_file_name (this_file, lang); > @@ -1375,6 +1377,7 @@ main (int argc, char **argv) > while (nincluded_files-- > 0) > fprintf (tagf, "\f\n%s,include\n", *included_files++); > > + free (*included_files); > if (fclose (tagf) == EOF) > pfatal (tagfile); > } > @@ -1400,6 +1403,8 @@ main (int argc, char **argv) > append_to_tagfile = true; > } > > + free (argbuffer); > + > tagf = fopen (tagfile, append_to_tagfile ? "ab" : "wb"); > if (tagf == NULL) > pfatal (tagfile); What is the rationale for these changes? If a variable is not used until the program exits, there's no need to free it.