From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#59918: 29.0.60; query-replace in the minibuffer lazy-highlights original buffer Date: Mon, 12 Dec 2022 20:07:53 +0200 Message-ID: <83iligqyva.fsf@gnu.org> References: <86y1rhhvsi.fsf@mail.linkov.net> <87edt6419r.fsf@gmail.com> <864ju0r002.fsf@mail.linkov.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36732"; mail-complaints-to="usenet@ciao.gmane.io" Cc: arstoffel@gmail.com, 59918@debbugs.gnu.org To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Mon Dec 12 19:09:15 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p4nEm-0009Fn-RI for geb-bug-gnu-emacs@m.gmane-mx.org; Mon, 12 Dec 2022 19:09:12 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p4nEe-0007r6-Dd; Mon, 12 Dec 2022 13:09:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4nEc-0007qT-Cx for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 13:09:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p4nEc-0008AS-4t for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 13:09:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p4nEb-0001uM-U3 for bug-gnu-emacs@gnu.org; Mon, 12 Dec 2022 13:09:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 12 Dec 2022 18:09:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59918 X-GNU-PR-Package: emacs Original-Received: via spool by 59918-submit@debbugs.gnu.org id=B59918.16708684877317 (code B ref 59918); Mon, 12 Dec 2022 18:09:01 +0000 Original-Received: (at 59918) by debbugs.gnu.org; 12 Dec 2022 18:08:07 +0000 Original-Received: from localhost ([127.0.0.1]:54466 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4nDf-0001tx-Lv for submit@debbugs.gnu.org; Mon, 12 Dec 2022 13:08:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:54808) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p4nDa-0001tA-Ls for 59918@debbugs.gnu.org; Mon, 12 Dec 2022 13:08:02 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4nDV-00081z-8k; Mon, 12 Dec 2022 13:07:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=axRsnFHtNm4VO7o5LTwKNyPqK2cNDzSPw72189oH3yw=; b=j4Slz09lqsFt XVmH6TIATMp/koUSTQzeW6VIvO/I6pWNP5bREZ2rrJUHLTFSFucyGaNXs/eH7PZx6EGXg5cq4BqDo MROqBMh+RUhiAvstksmBoDz0NVeP549Of2Dtb5RPPbzr3ecVe+L4i3WCK2BON2bxgW/n0ZPn0Ozr+ m/llLQddSiEICNaU54gUAwFag5bunOftPTVwUi/mKEMBzm+waI7CFHuh8R2O+1n3SGUOv5lxRgneO Xw77JXRpJl6M5vRvZQPV6ML9mJk2KypXG9HS3yc79R7Ivfti4ubxUlfqDuEjXfdnAFvI1HrADI5fG XYPoS7+StayMT60GTKzJzw==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p4nDU-0005Rb-Ed; Mon, 12 Dec 2022 13:07:52 -0500 In-Reply-To: <864ju0r002.fsf@mail.linkov.net> (message from Juri Linkov on Mon, 12 Dec 2022 19:43:25 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:250736 Archived-At: > Cc: 59918@debbugs.gnu.org > From: Juri Linkov > Date: Mon, 12 Dec 2022 19:43:25 +0200 > > >> 1. (setq enable-recursive-minibuffers t) > >> 1. M-! is C-a > >> 2. M-% is > >> > >> Matches are lazy-highlighted in the original buffer, > >> but the replacement is going to be used to replace > >> matches in the minibuffer. > > > > I guess this happens because minibuffer-selected-window returns the > > original buffer. I think this patch does the trick? > > We need to wait until Eli decides whether to install this > to emacs-29 or master. I admit that I don't understand the patch. minibuffer-selected-window returns a window, not a buffer, and it returns the window that you didn't want, AFAIU. Or maybe I don't understand the root cause -- could one of you please elaborate on what happens and why this is the right patch? Also, was this code introduced in Emacs 28/29 or earlier? Thanks.