From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60325: 30.0.50; [PATCH] Fix rfc822 date decode in newsticker Date: Thu, 29 Dec 2022 11:06:04 +0200 Message-ID: <83ilhu8tqb.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36895"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60325@debbugs.gnu.org To: LdBeth , Paul Eggert Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Dec 29 10:07:31 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pAoss-0009MU-Iz for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 29 Dec 2022 10:07:30 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pAosU-00054i-L1; Thu, 29 Dec 2022 04:07:06 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAosQ-00053m-Jl for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2022 04:07:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pAosQ-0003ll-By for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2022 04:07:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pAosQ-0002iZ-72 for bug-gnu-emacs@gnu.org; Thu, 29 Dec 2022 04:07:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 29 Dec 2022 09:07:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60325 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60325-submit@debbugs.gnu.org id=B60325.167230476610357 (code B ref 60325); Thu, 29 Dec 2022 09:07:02 +0000 Original-Received: (at 60325) by debbugs.gnu.org; 29 Dec 2022 09:06:06 +0000 Original-Received: from localhost ([127.0.0.1]:59243 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAorW-0002gz-Dj for submit@debbugs.gnu.org; Thu, 29 Dec 2022 04:06:06 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:33022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pAorQ-0002gA-Eg for 60325@debbugs.gnu.org; Thu, 29 Dec 2022 04:06:02 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAorI-0003aV-Pp; Thu, 29 Dec 2022 04:05:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=iYrXwMnimCxFdvTk0xDT8UzxLr0+dB+aDWiDpSQt9ZE=; b=OUPbRxFTSs5H Cs9ScnK+R4GtTwiadYPrQ4h4t33W1rwYwlmB76agoGCXALix9YnHzFRtZQkN4V+AkwRBedHxnF4Te UEa4G5s6/FoxmyHt2vNv9/rAu+5GmQ2UZtbs3f+iJVPa8sIO2+M0KCqJYNpz98apdyo6/VH4H88Sn 2lqgdl1vQB4qmuXFlKyaWdmxZPlb0bAcpcx0RDJGYB5I/Gyd2kpOx9GvfDUoxOLxPIQBVY4jfHr89 DuLK8+HsrIxtrR0O+KH8n/u3OIOfUXCTz7smKL65QZR9j7DwfX5WJepL3zLppDEw02z4pBV7TRFuZ LtrTPWQ07Csecy8A+d3jeQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pAorH-0001PL-Pw; Thu, 29 Dec 2022 04:05:52 -0500 In-Reply-To: (message from LdBeth on Sun, 25 Dec 2022 17:32:45 -0600) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:252020 Archived-At: > Date: Sun, 25 Dec 2022 17:32:45 -0600 > From: LdBeth > > `newsticker--decode-rfc822-date' matches North American timezone in > regex, but the actually time stamp conversion was not implemented. > This patch fixes the missing timezone conversion. Paul, any comments? If not, I intend to install this on master. Thanks. > From c06782604df686dd17e6eab5caf64e1717f519dc Mon Sep 17 00:00:00 2001 > From: LdBeth > Date: Sun, 25 Dec 2022 17:15:12 -0600 > Subject: [PATCH] Fix newsticker timezone decode > > `newsticker--decode-rfc822-date' has the regex pattern for > North American timezones but the actual timezone conversion > for them was not implmented. Now cond cases are added to > handle them as specified in RFC822. > --- > lisp/net/newst-backend.el | 20 +++++++++++++++----- > 1 file changed, 15 insertions(+), 5 deletions(-) > > diff --git a/lisp/net/newst-backend.el b/lisp/net/newst-backend.el > index af196cc..2a87742 100644 > --- a/lisp/net/newst-backend.el > +++ b/lisp/net/newst-backend.el > @@ -1623,7 +1623,7 @@ Sat, 07 Sep 2002 00:00:01 GMT > ":\\([0-9]\\{2\\}\\)" > ;; second > "\\(:\\([0-9]\\{2\\}\\)\\)?" > - ;; zone -- fixme > + ;; zone > "\\(\\s-+\\(" > "UT\\|GMT\\|EST\\|EDT\\|CST\\|CDT\\|MST\\|MDT\\|PST\\|PDT" > "\\|\\([-+]\\)\\([0-9]\\{2\\}\\)\\([0-9]\\{2\\}\\)" > @@ -1642,16 +1642,26 @@ Sat, 07 Sep 2002 00:00:01 GMT > (offset-hour (read (or (match-string 14 rfc822-string) > "0"))) > (offset-minute (read (or (match-string 15 rfc822-string) > - "0"))) > - ;;FIXME > - ) > + "0")))) > (when zone > (cond ((string= sign "+") > (setq hour (- hour offset-hour)) > (setq minute (- minute offset-minute))) > ((string= sign "-") > (setq hour (+ hour offset-hour)) > - (setq minute (+ minute offset-minute))))) > + (setq minute (+ minute offset-minute))) > + ((or (string= zone "UT") (string= zone "GMT")) > + nil) > + ((string= zone "EDT") > + (setq hour (+ hour 4))) > + ((or (string= zone "EST") (string= zone "CDT")) > + (setq hour (+ hour 5))) > + ((or (string= zone "CST") (string= zone "MDT")) > + (setq hour (+ hour 6))) > + ((or (string= zone "MST") (string= zone "PDT")) > + (setq hour (+ hour 7))) > + ((string= zone "PST") > + (setq hour (+ hour 8))))) > (condition-case error-data > (let ((i 1)) > (dolist (m '("Jan" "Feb" "Mar" "Apr" "May" "Jun" "Jul" "Aug" > -- > 2.33.1 >