From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60379: [PATCH] Eglot: don't use "nil" as minibuffer initial input Date: Thu, 12 Jan 2023 11:31:21 +0200 Message-ID: <83ilhcksk6.fsf@gnu.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8bit Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="9758"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60379@debbugs.gnu.org To: Eshel Yaron , =?UTF-8?Q?Jo=C3=A3o_?= =?UTF-8?Q?T=C3=A1vora?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Jan 12 10:32:23 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pFtwd-0002Ik-4f for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 12 Jan 2023 10:32:23 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pFtwW-0003BV-VS; Thu, 12 Jan 2023 04:32:17 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFtwJ-0003AL-5f for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 04:32:04 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1pFtwI-0007Ei-Tr for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 04:32:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1pFtwI-0006xo-Pg for bug-gnu-emacs@gnu.org; Thu, 12 Jan 2023 04:32:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 12 Jan 2023 09:32:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60379 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60379-submit@debbugs.gnu.org id=B60379.167351586926664 (code B ref 60379); Thu, 12 Jan 2023 09:32:02 +0000 Original-Received: (at 60379) by debbugs.gnu.org; 12 Jan 2023 09:31:09 +0000 Original-Received: from localhost ([127.0.0.1]:44672 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFtvR-0006w0-9L for submit@debbugs.gnu.org; Thu, 12 Jan 2023 04:31:09 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:57274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1pFtvL-0006vU-MF for 60379@debbugs.gnu.org; Thu, 12 Jan 2023 04:31:08 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFtvG-000753-7q; Thu, 12 Jan 2023 04:30:58 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ZXLMU5tr8KvzOxP7N70a8YsJLV/yaHa7VRl83m1tKWQ=; b=W8/oBPLSrzcju4u29rpW 2u9psqSUNkH8tXnklf/lvq7XcFlJNxPDLrC5RbnDYSQ/gJweMXTniungzkfGmUYaYps1DAt7RGWxR dTzW9YaUYNvHqBhopIK9xZu+jX0hnXNCiMsPYQiWbhLB9ufy0A6pxBRKxiGeziYTFUkvNaI5V6+si po4fLmzEJNulGrvgoB1VAwBiytgx7Mg3JaVJDa9ycjpkmejLfoEqfC5qjoKnuYlAhwnrRnr9oZlmG Ajw6qHpUpubVsVI+6X2kgRXHxxaPcl49ekwBppjwI5jRDIgvMCSAR3htw0aBLqByVLjRgFsIznj1u yjhK0dBkDWDYug==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pFtv5-0006Vx-IT; Thu, 12 Jan 2023 04:30:57 -0500 In-Reply-To: (bug-gnu-emacs@gnu.org) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:253192 Archived-At: > Date: Wed, 28 Dec 2022 14:22:17 +0200 > From: Eshel Yaron via "Bug reports for GNU Emacs, > the Swiss army knife of text editors" > > Currently, doing emacs -Q and followed by M-x eglot in the scratch > buffer results in a prompt for major mode to manage with LSP, but the > initial minibuffer input as well as the default value for the > completing-read call are both set to the string "nil", which is not very > helpful as that's not a valid input. > > This patch tweaks the prompt a little and avoids this issue by leaving > the minibuffer's initial input empty and making sure we don't set the > default value to "nil" either. Joćo, are you looking into this? WDYT?