From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#60418: [PATCH] Add :vc keyword to use-package Date: Fri, 05 May 2023 08:36:31 +0300 Message-ID: <83ild7jq5c.fsf@gnu.org> References: <87zgb6uk2r.fsf@hyperspace> <871qku220f.fsf@betli.tmit.bme.hu> <874jpq920b.fsf@posteo.net> <87cz4ezpwi.fsf@betli.tmit.bme.hu> <87h6tlinft.fsf@hyperspace> <87r0spa712.fsf@posteo.net> <87edopiif5.fsf@hyperspace> <87wn2bzvcp.fsf@hyperspace> <835y9vbyfr.fsf@gnu.org> <87mt36uwl8.fsf@hyperspace> <83ttxd8k1z.fsf@gnu.org> <87v8hrn56l.fsf@hyperspace> <87cz3w2lvb.fsf@posteo.net> <87jzy3ku6u.fsf@hyperspace> <87bkje93ou.fsf@posteo.net> <87y1mhihhy.fsf@hyperspace> <87ildbet2d.fsf@hyperspace> <831qjyoqj5.fsf@gnu.org> <87h6suolt2.fsf@hyperspace> <83ttwun4q4.fsf@gnu.org> <87o7n0fr9e.fsf@hyperspace> <878re3cqro.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26633"; mail-complaints-to="usenet@ciao.gmane.io" Cc: soliditsallgood@mailbox.org, felician.nemeth@gmail.com, 60418@debbugs.gnu.org, stefankangas@gmail.com To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri May 05 07:36:24 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1puo7D-0006jD-Px for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 05 May 2023 07:36:23 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1puo6y-0001os-Cf; Fri, 05 May 2023 01:36:08 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puo6s-0001oX-Ss for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 01:36:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1puo6s-0003Js-Jp for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 01:36:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1puo6s-0003RG-FZ for bug-gnu-emacs@gnu.org; Fri, 05 May 2023 01:36:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 05 May 2023 05:36:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60418 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 60418-submit@debbugs.gnu.org id=B60418.168326494813192 (code B ref 60418); Fri, 05 May 2023 05:36:02 +0000 Original-Received: (at 60418) by debbugs.gnu.org; 5 May 2023 05:35:48 +0000 Original-Received: from localhost ([127.0.0.1]:52893 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puo6d-0003Qi-R1 for submit@debbugs.gnu.org; Fri, 05 May 2023 01:35:48 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:36082) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1puo6b-0003QT-1E for 60418@debbugs.gnu.org; Fri, 05 May 2023 01:35:47 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puo6U-0001Kc-H4; Fri, 05 May 2023 01:35:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/809i1q1ByCZXu1NETEnhlA3K6pOAj5iT2qD9jJTVKo=; b=dA6yHmCWclnZ +/tJi/w9/FJZX9frvi/sYUTP+m6XL8hWNBuCbMgRDo38gbaxbXvpeVPJw/N5AkZ1h9G/RuszmOnUv wz0vn04rLRhHKRP0LNh3qb2HqIZDbURIU4VYe6YF4knSXCiPgiWkU+atrlRvARZXxG2iiyC+e+yoF MPFrP0Vn1kVBiOu5QwcLyPrnow5ZykGc5gf3NupXNB09QkcrrXKM7vBXIhTNV0UEAO6gKtXXFO/0M arZtl59yCXz59R2/mOnf6PgRSY/7jcwFwWClDz7T3PERZwYapJ+EnlBs3+G2Z9z1kqUv/sdwnjrin M/LtFBNL1yxenYWa1zlmkQ==; Original-Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1puo6U-0007cZ-4U; Fri, 05 May 2023 01:35:38 -0400 In-Reply-To: <878re3cqro.fsf@posteo.net> (message from Philip Kaludercic on Fri, 05 May 2023 05:04:59 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:261053 Archived-At: > From: Philip Kaludercic > Cc: Eli Zaretskii , 60418@debbugs.gnu.org, > felician.nemeth@gmail.com, stefankangas@gmail.com > Date: Fri, 05 May 2023 05:04:59 +0000 > > Tony Zorman writes: > > > You're right, but I don't think I'm using them as synonyms. There is a > > big difference between > > > > (package-vc-install "foo") > > > > which installs the latest "commit" (or revision, which I'm actually > > using as a synonym to commit) of a package, and > > > > (package-vc-install "foo" :last-release) > > > > which installs the latest "release". A release, as defined by > > package-vc.el seems to be 'the latest revision that bumps the "Version" > > tag.' It is queried in the package-vc--release-rev function, and > > actually retrieved in vc-retrieve-tag. The "Version" tag is, I think, > > just the "Version: XXX" string that's specified in the top comment of > > the main elisp file of the respective repository. > > How about we just say "the commit of the latest release"? When package-vc-install is used, what is "the latest release"? isn't that the HEAD of the default branch? IOW, what about packages that make no releases at all? > >> All I know is that when I've read the documentation you wrote, I asked > >> myself "what is meant by 'release' here?" I found the answer when you > >> later wrote "last commit". > >> > >> Are you talking about commits? More generally, what kind of "release > >> IDs" does :rev accept as its valid value? > > > > The :rev keyword accepts the same as REV of package-vc-install, which is > > either > > > > - nil, signaling that the latest commit should be installed, > > > > - :last-release, signaling that the last release should be installed, > > or > > > > - a "version string" appropriate for the respective version control > > system, specifying that version (e.g., a specific commit hash). > > All correct. > > >> I understand that the same confusion could exist elsewhere, but that > >> doesn't mean we should proliferate it or even live with what we have. > >> We should instead clarify this in every place where we use this > >> terminology. > >> > >> So let's figure out what are these "releases", and then let's examine > >> the existing and the new documentation and see if we need to get our > >> terminology right there. > > > > I totally agree, and I think the fact that "release" means "when has the > > release version as specified in the main .el file changed" should be > > documented somewhere (if it is I didn't see it). Sorry that this has > > caused so much confusion. > > Are there any other places where we can fix this confusion? I guess the documentation of package-vc-install shares these issues?