From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65496: 30.0.50; Issue with the regexp used to auto-detect PBM image data Date: Wed, 06 Sep 2023 19:00:28 +0300 Message-ID: <83il8n1ecj.fsf@gnu.org> References: <2fea228e-a8e8-5b8e-b91d-2d808d624649@orange.fr> <83wmx54z95.fsf@gnu.org> <6e4af25a-03b1-ef82-b1c0-2da81938e215@orange.fr> <83ledk5140.fsf@gnu.org> <92beee30-616b-0f9d-c3ec-52ef66fc9db3@orange.fr> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="18645"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65496-done@debbugs.gnu.org To: David Ponce Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Sep 06 18:03:07 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qduzi-0004bk-TI for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 06 Sep 2023 18:03:06 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qduyu-00060d-3R; Wed, 06 Sep 2023 12:02:16 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qduyg-0005mY-Lr for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 12:02:07 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qduyg-0005G3-1h for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 12:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qduyg-0005zA-ON for bug-gnu-emacs@gnu.org; Wed, 06 Sep 2023 12:02:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Wed, 06 Sep 2023 16:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 65496 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 65496@debbugs.gnu.org, eliz@gnu.org, da_vid@orange.fr Original-Received: via spool by 65496-done@debbugs.gnu.org id=D65496.169401606322885 (code D ref 65496); Wed, 06 Sep 2023 16:02:02 +0000 Original-Received: (at 65496-done) by debbugs.gnu.org; 6 Sep 2023 16:01:03 +0000 Original-Received: from localhost ([127.0.0.1]:37199 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qduxi-0005ws-DJ for submit@debbugs.gnu.org; Wed, 06 Sep 2023 12:01:03 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:39684) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qduxc-0005wK-HH for 65496-done@debbugs.gnu.org; Wed, 06 Sep 2023 12:01:00 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qduxU-00053H-B1; Wed, 06 Sep 2023 12:00:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=5cttabboHhsL8ucXbxR/lkP3HQllnYbyXZvFwAV6d2U=; b=EyvGyCi/YVzs rT3Z3LFApZvuAPARFQQJrYA4e8FVORvVdMALfkcdtnJhfG1t2YZmGEgy1id7QPq+W6treLHlescUZ Gt4TDWpACj0WHf9eH9/2Tkjn1FaZlvmfh1udHC7vt+P910gu29mH5zQYmmzXSjgO2J1Hg9FrxeGl2 KgQ27feFj/yMjaiCoui0N38i2qwAnA0+LCFBBiz4DlIj3XKREsdACKIm1Eh+vy20+QapvmVprCSza N5J/gHFJKg8o/9aAQXf8N3VuXYsgiH3Bdx7LRIemSALcc46Ry+pvpk/1DN3x6dUnkkpglXUsMRaSO SJEB8ynC+poD6E2eliZ17g==; In-Reply-To: <92beee30-616b-0f9d-c3ec-52ef66fc9db3@orange.fr> (message from David Ponce on Wed, 6 Sep 2023 16:05:39 +0200) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:269556 Archived-At: > Date: Wed, 6 Sep 2023 16:05:39 +0200 > Cc: 65496@debbugs.gnu.org > From: David Ponce > > >> Maybe for the use case of auto-detecting image type from image data, > >> my proposed patch to replace character class by a list of unambiguous > >> explicit character values in the regexp could make sense? > > > > Yes, it makes sense, but are you sure you mention there all the > > characters that can happen in PBM images, and only those characters? > > Yes, according to the specification of pbm available at > : > > "Each PBM image consists of the following: > > * A "magic number" for identifying the file type. > A pbm image's magic number is the two characters "P4". > > ==> * Whitespace (blanks, TABs, CRs, LFs). <== > > * The width in pixels of the image, formatted as ASCII characters in decimal. > > ..." Thanks, I've now installed your patch on the emacs-29 branch, and I'm closing this bug.