From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#65896: 30.0.50; folding text with text properties prevents background from extending past the newline Date: Fri, 22 Sep 2023 14:56:49 +0300 Message-ID: <83il82775q.fsf@gnu.org> References: <87ttrzmfua.fsf@strawberrytea.xyz> <83v8cfns1m.fsf@gnu.org> <87il8fm7x2.fsf@gmail.com> <40b4f4d3-34ae-4631-bebd-eefcd034d87e@app.fastmail.com> <83il8envaf.fsf@gnu.org> <87pm2d6mbj.fsf@localhost> <83bkdvaio4.fsf@gnu.org> <87jzsiy0ra.fsf@localhost> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="2563"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 65896@debbugs.gnu.org, kevin.legouguec@gmail.com, look@strawberrytea.xyz To: Ihor Radchenko Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Sep 22 13:58:11 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qjenT-0000Nh-2L for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 22 Sep 2023 13:58:11 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qjenC-0005l1-IC; Fri, 22 Sep 2023 07:57:54 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjenA-0005ko-0y for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 07:57:52 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qjen9-0002j0-PC for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 07:57:51 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qjenK-0001TW-2S for bug-gnu-emacs@gnu.org; Fri, 22 Sep 2023 07:58:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 22 Sep 2023 11:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 65896 X-GNU-PR-Package: emacs Original-Received: via spool by 65896-submit@debbugs.gnu.org id=B65896.16953838215592 (code B ref 65896); Fri, 22 Sep 2023 11:58:02 +0000 Original-Received: (at 65896) by debbugs.gnu.org; 22 Sep 2023 11:57:01 +0000 Original-Received: from localhost ([127.0.0.1]:35462 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjemL-0001S1-99 for submit@debbugs.gnu.org; Fri, 22 Sep 2023 07:57:01 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38326) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qjemG-0001Rm-GX for 65896@debbugs.gnu.org; Fri, 22 Sep 2023 07:56:59 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qjem0-0002VD-HW; Fri, 22 Sep 2023 07:56:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=H7df0zwV/oGrCUHEP3CHGu8QAeaieI4BIRYEc/EyC+o=; b=Vo7u1L/Nwi8o C+a3sm1xc970Iww+cLJ1BnKTDP/ItOQn2GoZl+aVY0tpnrjhBXPH7fLxHvc9FdNk6IDCbdPmqLyQ6 BLhEzL5B3umvw6C9cwAFat+xBOaJ1mSh92a0y05OvPKym6o8Fgli6/yDdbok+HMMGm6Aooa6HbIqX m/jMa2CEYpdjOz1rinw2nrZqgjI49tbHBXAtRlH+J+BfN10bBwiFdozz4wdUkdAxZqnWzzxgqQkIE 2MhtF2uAMpIvS/kfQjV9EXGmf/yv9Y2HxiBNQEH3lCp10k8HE7eCrHgMlJKzc7TVBAuBW6eXSMVAW 9ncUy/4FRa8PQT/noVj9kQ==; In-Reply-To: <87jzsiy0ra.fsf@localhost> (message from Ihor Radchenko on Fri, 22 Sep 2023 10:12:57 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271076 Archived-At: > From: Ihor Radchenko > Cc: look@strawberrytea.xyz, 65896@debbugs.gnu.org, kevin.legouguec@gmail.com > Date: Fri, 22 Sep 2023 10:12:57 +0000 > > Eli Zaretskii writes: > > >> Are you sure? I am looking at `extend_face_to_end_of_line' and it looks > >> like there is nothing preventing it from accessing it->glyph_row->glyphs > >> array to look backwards into preceding glyphs. > > > > First, glyphs have only partial information about the original face > > properties. IOW, the produced glyph row doesn't have all the info > > that the original text had. > > > > And second, I don't see how the accessibility to the glyphs is > > relevant to the issue at hand. Suppose the visible text of a line is: > > > > aaabbbbxxx > > > > where each letter represents some character with different face -- you > > want Emacs to extend face 'a' after the end of the line, not the face > > 'x', just because the line started with characters whose face was > > 'a'?? that's what the OP said, AFAIU. > > I am also not a big fan of using the first glyph/letter in the line. > > What about not extending the face unless the last 2 glyphs have eq face > or we have a single glyph in a row? That's a backward-incompatible change, so we cannot do that.