From: Eli Zaretskii <eliz@gnu.org>
To: Jim Porter <jporterbugs@gmail.com>
Cc: 65685@debbugs.gnu.org, michael.albinus@gmx.de
Subject: bug#65685: 29.1; Inconsistent behavior of quoted file name "/:~" across platforms
Date: Sat, 14 Oct 2023 10:42:25 +0300 [thread overview]
Message-ID: <83il79sl9a.fsf@gnu.org> (raw)
In-Reply-To: <c8a563de-d55d-1f8a-0f2b-c6f8e6f0d495@gmail.com> (message from Jim Porter on Fri, 13 Oct 2023 17:31:32 -0700)
> Cc: 65685@debbugs.gnu.org
> Date: Fri, 13 Oct 2023 17:31:32 -0700
> From: Jim Porter <jporterbugs@gmail.com>
>
> On 10/13/2023 7:26 AM, Michael Albinus wrote:
> > This is a Tramp bug. I've fixed this in the emacs-29 branch, and merged
> > it to the master branch afterwards. The fix shall solve both scenarios,
> > with and without the patch I've posted earlier here.
> >
> > Could you pls test, whether the patch behaves now as intended?
>
> I think this works now, thanks. (Note that I just eval'ed the new
> version of 'tramp-sh-handle-expand-file-name' on MS-Windows to test
> things out, since I don't have a build environment set up on my
> MS-Windows system.)
>
> So with the patch you merged to Tramp, plus your other one for
> "lisp/files.el", I think this is all working consistently now.
The added test fails on MS-Windows:
Test files-tests-file-name-non-special-expand-file-name-tilde condition:
(ert-test-failed
((should
(equal
(expand-file-name nospecial)
(expand-file-name ...)))
:form
(equal "/:c:/Documents and Settings/Zaretzky/Local Settings/Temp/files-testsvIKNPk/files-testse2cUFY" "c:/Documents and Settings/Zaretzky/Local Settings/Temp/files-testsvIKNPk/files-testse2cUFY")
:value nil :explanation
(arrays-of-different-length 92 90 "/:c:/Documents and Settings/Zaretzky/Local Settings/Temp/files-testsvIKNPk/files-testse2cUFY" "c:/Documents and Settings/Zaretzky/Local Settings/Temp/files-testsvIKNPk/files-testse2cUFY" first-mismatch-at 0)))
I tried to understand the idea of the change, or even the actual root
cause of the problem, but couldn't find that in the discussion or the
code. It doesn't help that file-name-non-special has no doc string
and no documentation I could find about what it's supposed to do.
Let's please discuss this now, because I tend just to revert the
change on the emacs-29 branch, as it's too late there for untested
ideas for obscure problems.
next prev parent reply other threads:[~2023-10-14 7:42 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-01 19:22 bug#65685: 29.1; Inconsistent behavior of quoted file name "/:~" across platforms Jim Porter
2023-10-03 11:22 ` Michael Albinus
2023-10-10 4:27 ` Jim Porter
2023-10-13 14:26 ` Michael Albinus
2023-10-14 0:31 ` Jim Porter
2023-10-14 7:42 ` Michael Albinus
2023-10-14 7:42 ` Eli Zaretskii [this message]
2023-10-14 7:48 ` Michael Albinus
2023-10-14 10:56 ` Michael Albinus
2023-10-14 11:25 ` Eli Zaretskii
2023-10-14 14:29 ` Michael Albinus
2023-10-14 16:48 ` Michael Albinus
2023-10-14 19:07 ` Eli Zaretskii
2023-10-15 7:11 ` Michael Albinus
2023-10-15 9:36 ` Eli Zaretskii
2023-10-15 9:50 ` Michael Albinus
2023-10-15 9:58 ` Eli Zaretskii
2023-10-15 10:29 ` Michael Albinus
2023-10-15 20:12 ` Mattias Engdegård
2023-10-16 7:07 ` Michael Albinus
2023-10-16 7:30 ` Mattias Engdegård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83il79sl9a.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=65685@debbugs.gnu.org \
--cc=jporterbugs@gmail.com \
--cc=michael.albinus@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.