From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#67046: 29.1.50; map-y-or-n-p infinite loops if it's at the end of a kmacro Date: Fri, 10 Nov 2023 20:55:48 +0200 Message-ID: <83il69xwsr.fsf@gnu.org> References: Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36208"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 67046@debbugs.gnu.org To: Spencer Baugh , Stefan Monnier Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Nov 10 19:56:35 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r1WgE-00039I-HY for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 10 Nov 2023 19:56:34 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r1Wg6-0005Px-Lz; Fri, 10 Nov 2023 13:56:26 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1Wg4-0005Pl-4c for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 13:56:24 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r1Wg2-00012o-Bj for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 13:56:23 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r1Wgg-0004UY-1D for bug-gnu-emacs@gnu.org; Fri, 10 Nov 2023 13:57:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Nov 2023 18:57:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 67046 X-GNU-PR-Package: emacs Original-Received: via spool by 67046-submit@debbugs.gnu.org id=B67046.169964260417239 (code B ref 67046); Fri, 10 Nov 2023 18:57:02 +0000 Original-Received: (at 67046) by debbugs.gnu.org; 10 Nov 2023 18:56:44 +0000 Original-Received: from localhost ([127.0.0.1]:50864 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1WgO-0004Ty-93 for submit@debbugs.gnu.org; Fri, 10 Nov 2023 13:56:44 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46936) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r1WgK-0004Th-9f for 67046@debbugs.gnu.org; Fri, 10 Nov 2023 13:56:42 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r1Wfa-00010a-47; Fri, 10 Nov 2023 13:55:54 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=7nqvX/0EMI8UgcGza8KtVOCmBJwKrBKEBKLtAZcTnzc=; b=Rh/DL5dBiSwu oFkopjuwjg6+kJzheB4QLwHQJEihwaAvHmF6pz6ZI3QL6zMpSyTcEZMTj89tHmESFIv+/lK0CuUBe o7yFZO4s7vrEMP7M5/QO2PpelXf70D9gjZrb5XWKmHxjIFcXyDu2snMdUTyTwKIMKzIh9vqpZb/Na U+Wg1yWzJOQlRlaGE01W5rmdoONuFJgp8n6rlC5mIwCajON+uY2zuVIPvWdvYaqyHfwKzCbeP/twJ hHMR0WHe+AR6jLXD6MEWmIjgrcCNrzVpK9ynIGam+pb10/4pgEGKf+o7ZyzwsoE3Yia8gFA4HDw77 kMLt410RB4JZd+KXdRHLtQ==; In-Reply-To: (message from Spencer Baugh on Fri, 10 Nov 2023 11:47:36 -0500) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275488 > From: Spencer Baugh > Date: Fri, 10 Nov 2023 11:47:36 -0500 > > >From d7aa9644b308a936926b1074d0f6eac3e425b011 Mon Sep 17 00:00:00 2001 > From: Spencer Baugh > Date: Fri, 10 Nov 2023 11:27:10 -0500 > Subject: [PATCH] Don't infinite loop in map-y-or-n-p if at the end of kmacro > > Previously, if map-y-or-n-p got -1 from read-event (indicating no > input due to the end of a keyboard macro), it would just infinite > loop. > > Now it behaves like other commands which use read-event/read-char/etc, > and just errors when we try to look up -1 in our keymap and find > nothing. > > Also, just for the sake of users, print a slightly prettier message > when this happens. > > * lisp/emacs-lisp/map-ynp.el (map-y-or-n-p): Don't loop if we reach > the end of a keyboard macro. (Bug#67046) You have removed the loop, so now the "try again" part is no longer working. How can we be sure this doesn't introduce some regression? Do you understand why this loop was added, in commit 3f72fac865? If so, can you explain why it was needed? I have added Stefan to the discussion.