From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#66394: 29.1; Make register-read-with-preview more useful Date: Sat, 25 Nov 2023 22:10:14 +0200 Message-ID: <83il5pbnmh.fsf@gnu.org> References: <87il7ib6cu.fsf@posteo.net> <87sf67qqmp.fsf@web.de> <875y3386ep.fsf@posteo.net> <87a5sddh14.fsf@web.de> <8734y5vnj7.fsf@posteo.net> <87bkcslr18.fsf@web.de> <87y1fwtyrl.fsf@posteo.net> <87y1fut1wp.fsf@web.de> <87ttqgpjiz.fsf@posteo.net> <87wmvbibpr.fsf@web.de> <877cnb2n63.fsf@posteo.net> <8734xyc8z0.fsf@web.de> <87zg05rewi.fsf@posteo.net> <87ttqcg8gw.fsf@web.de> <87h6mcr8ol.fsf@posteo.net> <87r0l73029.fsf@web.de> <877cmdx8ud.fsf@posteo.net> <87sf50s1gh.fsf@posteo.net> <83o7ficesp.fsf@gnu.org> <878r6leh9d.fsf@posteo.net> Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28259"; mail-complaints-to="usenet@ciao.gmane.io" Cc: michael_heerdegen@web.de, 66394@debbugs.gnu.org, monnier@iro.umontreal.ca, stefankangas@gmail.com To: Thierry Volpiatto Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Nov 25 21:11:10 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r6yzd-0007CC-SA for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 25 Nov 2023 21:11:10 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1r6yzS-0004a1-Tk; Sat, 25 Nov 2023 15:10:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6yzR-0004Zf-Qq for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 15:10:57 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1r6yzR-0006yE-IE for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 15:10:57 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1r6yzW-0002Hn-4V for bug-gnu-emacs@gnu.org; Sat, 25 Nov 2023 15:11:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 25 Nov 2023 20:11:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 66394 X-GNU-PR-Package: emacs Original-Received: via spool by 66394-submit@debbugs.gnu.org id=B66394.17009430438762 (code B ref 66394); Sat, 25 Nov 2023 20:11:02 +0000 Original-Received: (at 66394) by debbugs.gnu.org; 25 Nov 2023 20:10:43 +0000 Original-Received: from localhost ([127.0.0.1]:40353 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6yzD-0002HG-B6 for submit@debbugs.gnu.org; Sat, 25 Nov 2023 15:10:43 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45398) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1r6yzA-0002H0-4t for 66394@debbugs.gnu.org; Sat, 25 Nov 2023 15:10:41 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1r6yyz-0006sN-6h; Sat, 25 Nov 2023 15:10:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=y2nXnjDx93GIrczvUMjAdtaRBxMsBcJxqNgPQh5YcuA=; b=DdTTFtg75dsq SN6Fan/W4t+qvpIdO325NUNlG3SGMG623PtgM8ksXwVdDmDl6IZbcmN57EmYUCPfEpIM1yPrL+B8B 4OqjPcAFSPt/y0DP1wz/Rb8WH2V88yy+n1VKimIE49V+sioGDs2us4q149gAxAJ5MydNDWGGmfxHQ JhK5XD3O1OKmXSFm6gjXXUgm2dYGaEEOLmQF+KaUvqPILKxUkj097rXD/l+xVEZZbJvVhTWt/DZSO U32Sy3d2m76VFcgIXYf+PvAxcZ6/G0dCersmwo2IzJUgXCc3e49FBTgvMmt1SabN5kJ7eopUBYdY3 orxCw3meCWULPAMwQ5+R3g==; In-Reply-To: <878r6leh9d.fsf@posteo.net> (message from Thierry Volpiatto on Sat, 25 Nov 2023 19:59:26 +0000) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:275018 Archived-At: > From: Thierry Volpiatto > Cc: monnier@iro.umontreal.ca, michael_heerdegen@web.de, > stefankangas@gmail.com, 66394@debbugs.gnu.org > Date: Sat, 25 Nov 2023 19:59:26 +0000 > > > ELC ../lisp/register.elc > > > > In toplevel form: > > register.el:33:37: Warning: `eql' called with 1 argument, but requires 2 > > register.el:33:45: Warning: reference to free variable `integer' > > I have not these warnings. Strange. Maybe Stefan can explain how could that happen. > > This then fails the build, since 'register' is preloaded. > > Here it is building fine, this from the last Emacs master from tonight. I'm also applying to master, obviously. > > Thierry, can you please fix the code, so that I could install it? Or > > what am I missing? > > Don't know, did you "make clean" first? How would "make clean" help? I did remove register.elc, it didn't help. > NOTE: I leaved the patch like this but it needs the change suggested by > Stefan before merging (or with an extra commit) see above. OK, so I guess I shouldn't have tried to install it. > > P.S. Also, the log message is not according to our conventions. > > I don't remember now what are your conventions for commits, perhaps you > can correct it if needed? Of course, I can correct it. I just thought that if you are going to submit a fixed patch, perhaps you could fix the log message as well, to spare me some manual work. Never mind now, since I'm not going to install it yet. Thanks.