From: Eli Zaretskii <eliz@gnu.org>
To: "João Távora" <joaotavora@gmail.com>
Cc: emacs-devel@gnu.org
Subject: Re: master d9b5f618baa 2/4: Eglot: introduce eglot-events-buffer-config
Date: Wed, 27 Dec 2023 19:29:20 +0200 [thread overview]
Message-ID: <83il4j8sgf.fsf@gnu.org> (raw)
In-Reply-To: <CALDnm50P1ftm3JF85kuU8FnrozLRMv4SQNmMQbJt+j3iBNjd2A@mail.gmail.com> (message from João Távora on Wed, 27 Dec 2023 17:07:22 +0000)
> From: João Távora <joaotavora@gmail.com>
> Date: Wed, 27 Dec 2023 17:07:22 +0000
> Cc: emacs-devel@gnu.org
>
> On Wed, Dec 27, 2023 at 4:47 PM Eli Zaretskii <eliz@gnu.org> wrote:
> >
> > Since changing this defcustom needs some code to be run in order to
> > make the changes effective, I wonder whether this defcustom could use
> > :set to run that code automatically?
>
> Read above in the same diff:
>
> @c FIXME: Shouldn't the defcustom do this by itself using the :set
> -@c attribute?
> +@c attribute? Maybe not because reconnecting is a complex task.
> @xref{Troubleshooting Eglot}, for when this could be useful.
>
> IOW Reconnecting to a server may trash useful caches, fail due
> to numerous reasons, etc... We don't want to initiate it just
> because a user changed a preference.
Shouldn't these caveats be in the doc string, where you tell users to
invoke eglot-reconnect?
next prev parent reply other threads:[~2023-12-27 17:29 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-27 16:46 master d9b5f618baa 2/4: Eglot: introduce eglot-events-buffer-config Eli Zaretskii
2023-12-27 17:07 ` João Távora
2023-12-27 17:29 ` Eli Zaretskii [this message]
2023-12-27 17:38 ` João Távora
2023-12-27 18:51 ` Eli Zaretskii
2023-12-27 19:05 ` João Távora
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83il4j8sgf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=joaotavora@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.