all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: mardani29@yahoo.es
Cc: 67204@debbugs.gnu.org, awrhygty@outlook.com
Subject: bug#67204: 29.1; request: always echo EMOJI name while emoji-list
Date: Sat, 30 Dec 2023 11:20:59 +0200	[thread overview]
Message-ID: <83il4g3v2c.fsf@gnu.org> (raw)
In-Reply-To: <83h6k157zk.fsf@gnu.org> (message from Eli Zaretskii on Fri, 29 Dec 2023 17:44:15 +0200)

> Cc: 67204@debbugs.gnu.org, awrhygty@outlook.com
> Date: Fri, 29 Dec 2023 17:44:15 +0200
> From: Eli Zaretskii <eliz@gnu.org>
> 
> > Cc: 67204@debbugs.gnu.org, awrhygty@outlook.com
> > Date: Fri, 29 Dec 2023 17:38:59 +0200
> > From: Eli Zaretskii <eliz@gnu.org>
> > 
> > I cannot reproduce this.  I get:
> > 
> >   person getting massage
> >   person getting haircut
> >   person walking
> >   person running
> >   people with bunny ears
> >   woman dancing
> 
> Sorry, this was in Emacs 29.  In Emacs 20 I indeed see what you see.
> (But the OP used Emacs 29.1.)  Will investigate.

OK, I see the issue now: it's because C-f/C-b still moves by one
character in this buffer, and we basically rely on point-adjustment to
move to the next emoji.  The cases where the echo is incorrect, point
after C-f is still on the same emoji, not on the next one, whereas
after point adjustment it is on the next emoji.

The solution to that is not to show the emoji name from the
post-command-hook, but from an idle timer.  Like this:

  (add-hook #'post-command-hook
	    (lambda ()
	      (run-with-idle-timer 0.02 nil
				   (lambda ()
				     (when-let
					 ((glyph (get-text-property (point)
								    'emoji-glyph))
					  (name (emoji--name glyph)))
				       (message "%s" name)))))
	    nil 'local)

We could have this as an optional feature, or we could leave this
alone and rely on users who want this to customize their Emacs like
above.





  reply	other threads:[~2023-12-30  9:20 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-15  7:04 bug#67204: 29.1; request: always echo EMOJI name while emoji-list awrhygty
2023-12-25 18:59 ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-25 19:32   ` Eli Zaretskii
2023-12-25 20:52     ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-29  7:44       ` Eli Zaretskii
2023-12-29 15:12         ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors
2023-12-29 15:38           ` Eli Zaretskii
2023-12-29 15:44             ` Eli Zaretskii
2023-12-30  9:20               ` Eli Zaretskii [this message]
2024-01-09 20:02                 ` Eli Zaretskii
2023-12-29 17:08             ` Daniel Martín via Bug reports for GNU Emacs, the Swiss army knife of text editors

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83il4g3v2c.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=67204@debbugs.gnu.org \
    --cc=awrhygty@outlook.com \
    --cc=mardani29@yahoo.es \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.