From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Include guards Date: Thu, 08 Jul 2010 20:49:55 +0300 Message-ID: <83hbk97tj0.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1278612548 2995 80.91.229.12 (8 Jul 2010 18:09:08 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Thu, 8 Jul 2010 18:09:08 +0000 (UTC) To: emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 08 20:09:05 2010 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OWvWw-000096-Cx for ged-emacs-devel@m.gmane.org; Thu, 08 Jul 2010 20:09:02 +0200 Original-Received: from localhost ([127.0.0.1]:41403 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWvWv-0001Jt-Nr for ged-emacs-devel@m.gmane.org; Thu, 08 Jul 2010 14:09:01 -0400 Original-Received: from [140.186.70.92] (port=43963 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OWvWi-0000tZ-BF for emacs-devel@gnu.org; Thu, 08 Jul 2010 14:08:49 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OWvHB-0001Pp-Fq for emacs-devel@gnu.org; Thu, 08 Jul 2010 13:52:46 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:37065) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OWvHB-0001Pd-9M for emacs-devel@gnu.org; Thu, 08 Jul 2010 13:52:45 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0L5900F002VY1800@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Thu, 08 Jul 2010 20:51:55 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.127.120.144]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0L5900A4M2YIDUB0@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Thu, 08 Jul 2010 20:51:55 +0300 (IDT) In-reply-to: "emacs-diffs-request@gnu.org"'s message of Thu, 08 Jul 2010 02:17:28 -0400 X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:126916 Archived-At: I don't understand the removal of some of the include guards in revno 100751: the "#ifdef ..." guards were removed, but they are still used and/or defined by src/config.h. Examples: . "#ifdef HAVE_CONFIG_H" was removed from bidi.c, but src/Makefile.in still puts -DHAVE_CONFIG_H into the compilation command line. Moreover, some source files still use it. . "#ifdef HAVE_STRING_H" was removed, but src/config.h still uses it. What am I missing here? What is the plan regarding these guards?