From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Use gnulib's dup2 module instead of rolling our own Date: Sat, 25 Jun 2011 13:48:22 +0300 Message-ID: <83hb7etceh.fsf@gnu.org> References: <4E05A0B7.2020901@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: lo.gmane.org X-Trace: dough.gmane.org 1308999015 5426 80.91.229.12 (25 Jun 2011 10:50:15 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 25 Jun 2011 10:50:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Jun 25 12:50:04 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QaQR6-0001SN-FM for ged-emacs-devel@m.gmane.org; Sat, 25 Jun 2011 12:50:00 +0200 Original-Received: from localhost ([::1]:38894 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaQR5-00009v-Q5 for ged-emacs-devel@m.gmane.org; Sat, 25 Jun 2011 06:49:59 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:48980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaQQs-00009q-83 for emacs-devel@gnu.org; Sat, 25 Jun 2011 06:49:47 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QaQQr-0002t7-4d for emacs-devel@gnu.org; Sat, 25 Jun 2011 06:49:46 -0400 Original-Received: from mtaout20.012.net.il ([80.179.55.166]:61425) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QaQQq-0002t1-T9 for emacs-devel@gnu.org; Sat, 25 Jun 2011 06:49:45 -0400 Original-Received: from conversion-daemon.a-mtaout20.012.net.il by a-mtaout20.012.net.il (HyperSendmail v2007.08) id <0LNC00H00DJWWN00@a-mtaout20.012.net.il> for emacs-devel@gnu.org; Sat, 25 Jun 2011 13:48:19 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([77.124.152.149]) by a-mtaout20.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LNC00HXXE0HYN00@a-mtaout20.012.net.il>; Sat, 25 Jun 2011 13:48:19 +0300 (IDT) In-reply-to: <4E05A0B7.2020901@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 80.179.55.166 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:140955 Archived-At: > Date: Sat, 25 Jun 2011 01:47:51 -0700 > From: Paul Eggert > > Here's a patch to simplify Emacs proper, and work around some > platforms' dup2 bugs, by using gnulib's dup2 module in place of the > dup2 code in sysdep.c. Most of this patch is automatically-generated; > the by-hand stuff is in Makefile.in (one line added), configure.in > (one word deleted), and src/sysdep.c (31 lines deleted). > > I don't think this affects the Windows port but am giving a heads-up > before committing. Thanks. The Windows port isn't affected, because sysdep.c defines the dup2 replacement only for systems that define USG, and Windows doesn't.