all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Juri Linkov <juri@jurta.org>
Cc: 10705@debbugs.gnu.org
Subject: bug#10705: 24.0.93; Collect strings matching regexp from Isearch
Date: Fri, 03 Feb 2012 09:38:53 +0200	[thread overview]
Message-ID: <83haz8fjsi.fsf@gnu.org> (raw)
In-Reply-To: <874nvac6us.fsf@mail.jurta.org>

> From: Juri Linkov <juri@jurta.org>
> Date: Thu, 02 Feb 2012 23:02:03 +0200
> 
> Currently `isearch-occur' is not in sync with the interactive specification
> of `occur' that provides a new feature of `C-u M-x occur RET' that collects
> the matching strings into the `*Occur*' buffer without line numbers.
> 
> The following patch syncs code from `occur-read-primary-args' to `isearch-occur'.

Btw, while at that, how about fixing the doc string as well.  What it
says now, viz.

>  Interactively, REGEXP is the current search regexp or a quoted search
>  string.  NLINES has the same meaning as in `occur'."

is not clear enough: what is a "quoted search string"?  I'd suggest to
describe explicitly the 3 cases handled by the code:

> +	  (regexp (cond
> +		   (isearch-word (word-search-regexp isearch-string))
> +		   (isearch-regexp isearch-string)
> +		   (t (regexp-quote isearch-string)))))

and refer to the relevant string in each case.





  reply	other threads:[~2012-02-03  7:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-02 21:02 bug#10705: 24.0.93; Collect strings matching regexp from Isearch Juri Linkov
2012-02-03  7:38 ` Eli Zaretskii [this message]
2012-02-04  0:14   ` Juri Linkov
2012-02-04  7:26     ` Eli Zaretskii
2012-02-04 14:41       ` Drew Adams
2012-02-23  0:38       ` Juri Linkov
2012-02-23  0:57 ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83haz8fjsi.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=10705@debbugs.gnu.org \
    --cc=juri@jurta.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.