Re: Booleans

[Eli Zaretskii <eliz@gnu.org>]

> Date: Sun, 15 Dec 2013 15:03:50 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: emacs-devel@gnu.org
> 
> > should have been a separate commit, as
> > it is not a mechanical replacement, far from it.
> 
> It was a judgment call.  Perhaps I should have separated it
> out, though it's no big deal.  It was a case of an int value
> being used as a boolean with values 0 and -1.

Yes, but you also removed several struct members in that hunk.

> >   -#if 0
> >   +#if false
> > 
> > ... I'm afraid I don't see the point
> 
> I tried to be reasonably systematic in replacing uses of 0
> and 1 as booleans in the set of files that I was looking at;
> this included the use of booleans in preprocessor
> expressions.  It would be an odd style to use '0' for false
> preprocessor expressions, while using 'false' for false
> expressions everywhere else.

"#if false" looks very odd to me, I don't think I've ever seen that.