From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Patches with independent changes Date: Fri, 24 Jan 2014 23:39:40 +0200 Message-ID: <83ha8tcb4z.fsf@gnu.org> References: <8361pbg5vy.fsf@gnu.org> <52E08D31.3080801@cs.ucla.edu> <8338kffj7m.fsf@gnu.org> <52E0A0ED.4020601@cs.ucla.edu> <83y526el6z.fsf@gnu.org> <52E18EC0.7090302@cs.ucla.edu> <83lhy5ests.fsf@gnu.org> <52E2277B.9000205@cs.ucla.edu> <83bnz1eo1x.fsf@gnu.org> <52E29827.7060209@cs.ucla.edu> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1390599600 13249 80.91.229.3 (24 Jan 2014 21:40:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 24 Jan 2014 21:40:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 24 22:40:06 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1W6oTs-0004dP-Vg for ged-emacs-devel@m.gmane.org; Fri, 24 Jan 2014 22:40:05 +0100 Original-Received: from localhost ([::1]:48998 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6oTs-000724-FB for ged-emacs-devel@m.gmane.org; Fri, 24 Jan 2014 16:40:04 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:33842) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6oTi-0006ql-LP for emacs-devel@gnu.org; Fri, 24 Jan 2014 16:39:59 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1W6oTd-0000TU-HI for emacs-devel@gnu.org; Fri, 24 Jan 2014 16:39:54 -0500 Original-Received: from mtaout28.012.net.il ([80.179.55.184]:41655) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1W6oTd-0000TJ-A9 for emacs-devel@gnu.org; Fri, 24 Jan 2014 16:39:49 -0500 Original-Received: from conversion-daemon.mtaout28.012.net.il by mtaout28.012.net.il (HyperSendmail v2007.08) id <0MZX00400C4UCY00@mtaout28.012.net.il> for emacs-devel@gnu.org; Fri, 24 Jan 2014 23:41:08 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout28.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0MZX001CNDKJAX90@mtaout28.012.net.il>; Fri, 24 Jan 2014 23:41:08 +0200 (IST) In-reply-to: <52E29827.7060209@cs.ucla.edu> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.184 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:169033 Archived-At: > Date: Fri, 24 Jan 2014 08:43:19 -0800 > From: Paul Eggert > CC: emacs-devel@gnu.org > > [retitling from "Changes in update-game-score.c"] [Why?] > Eli Zaretskii wrote: > > > chmod is documented to be able to return both negative and positive values > > Really? Where is it documented to do that? I could have sworn that I saw it on MSDN, but I cannot find it now, so apologies about that part. > Even if you're correct, which I doubt, trunk bzr 116116 would still be > an example of what you're calling a "sumo" patch -- a patch containing > multiple independent changes. One change addresses WINDOWSNT's lack of > fchmod. Another addresses the perhaps-hypothetical issue that chmod can > return positive values. No, they both address the fact that fchmod is not available on Windows. One without the other would break the build on Windows. That I used < rather than != is immaterial, because both are correct in this case.