all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: emacs-devel@gnu.org
Subject: Re: Patches with independent changes
Date: Fri, 24 Jan 2014 23:39:40 +0200	[thread overview]
Message-ID: <83ha8tcb4z.fsf@gnu.org> (raw)
In-Reply-To: <52E29827.7060209@cs.ucla.edu>

> Date: Fri, 24 Jan 2014 08:43:19 -0800
> From: Paul Eggert <eggert@cs.ucla.edu>
> CC: emacs-devel@gnu.org
> 
> [retitling from "Changes in update-game-score.c"]

[Why?]

> Eli Zaretskii wrote:
> 
> > chmod is documented to be able to return both negative and positive values
> 
> Really?  Where is it documented to do that?

I could have sworn that I saw it on MSDN, but I cannot find it now, so
apologies about that part.

> Even if you're correct, which I doubt, trunk bzr 116116 would still be 
> an example of what you're calling a "sumo" patch -- a patch containing 
> multiple independent changes. One change addresses WINDOWSNT's lack of 
> fchmod. Another addresses the perhaps-hypothetical issue that chmod can 
> return positive values.

No, they both address the fact that fchmod is not available on
Windows.  One without the other would break the build on Windows.
That I used < rather than != is immaterial, because both are correct
in this case.



  reply	other threads:[~2014-01-24 21:39 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-22 19:42 Changes in update-game-score.c Eli Zaretskii
2014-01-22 19:50 ` David Kastrup
2014-01-22 20:07   ` Eli Zaretskii
2014-01-22 20:10     ` David Kastrup
2014-01-23  1:51     ` Glenn Morris
2014-01-23  3:33       ` Paul Eggert
2014-01-23  3:53         ` Eli Zaretskii
2014-01-23 16:02           ` Eli Zaretskii
2014-01-23  3:58         ` Glenn Morris
2014-01-23  3:32 ` Paul Eggert
2014-01-23  3:52   ` Eli Zaretskii
2014-01-23  3:59     ` Glenn Morris
2014-01-23  4:30       ` Glenn Morris
2014-01-23  4:33         ` Glenn Morris
2014-01-23  4:56     ` Paul Eggert
2014-01-23 16:07       ` Eli Zaretskii
2014-01-23 18:18         ` Paul Eggert
2014-01-23 20:27         ` Juanma Barranquero
2014-01-23 21:50           ` Paul Eggert
2014-01-23 22:39             ` Juanma Barranquero
2014-01-24  7:34             ` Eli Zaretskii
2014-01-24  8:42               ` Paul Eggert
2014-01-24  9:17                 ` Eli Zaretskii
2014-01-24 15:29                   ` Jarek Czekalski
2014-01-24 15:40                     ` Eli Zaretskii
2014-01-24 15:42                     ` change the Subject line when you change topics [was: Changes in update-game-score.c] Drew Adams
2014-01-25 10:00                       ` Jarek Czekalski
2014-01-24 16:43                   ` Patches with independent changes Paul Eggert
2014-01-24 21:39                     ` Eli Zaretskii [this message]
2014-01-24 22:34                       ` Paul Eggert
2014-01-25  7:22                         ` Eli Zaretskii
2014-01-25 17:01                           ` Paul Eggert
2014-01-25 17:22                             ` Eli Zaretskii
2014-01-25 17:25                             ` Eli Zaretskii
2014-01-25 20:58                               ` Paul Eggert
2014-01-26  3:47                                 ` Eli Zaretskii
2014-01-26  7:41                                   ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83ha8tcb4z.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.