From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#18196: 24.4.50; crash when setting face background in terminal frame Date: Fri, 08 Aug 2014 12:19:26 +0300 Message-ID: <83ha1nmj8h.fsf@gnu.org> References: <87ppgf4aki.fsf@gateway.local.navru.net> <53E09B27.7050100@gmx.at> <53E0AA14.3010501@gmx.at> <87siladgd0.fsf@gateway.local.navru.net> <53E118CA.2090602@gmx.at> <87tx5qeort.fsf@gateway.local.navru.net> <87r40ueied.fsf@gateway.local.navru.net> <53E1F869.9060402@gmx.at> <87egwt4hs9.fsf@gateway.local.navru.net> <53E3965B.8070205@gmx.at> <87sil8cgk5.fsf@gateway.local.navru.net> <53E48D99.9040307@gmx.at> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1407489635 3322 80.91.229.3 (8 Aug 2014 09:20:35 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 8 Aug 2014 09:20:35 +0000 (UTC) Cc: 18196@debbugs.gnu.org, penthief@SDF.ORG, nicolasavru@gmail.com To: martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Aug 08 11:20:23 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XFgLP-0005TL-W7 for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Aug 2014 11:20:16 +0200 Original-Received: from localhost ([::1]:50048 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFgLP-0000tC-IJ for geb-bug-gnu-emacs@m.gmane.org; Fri, 08 Aug 2014 05:20:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50190) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFgLI-0000ke-1g for bug-gnu-emacs@gnu.org; Fri, 08 Aug 2014 05:20:12 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XFgLD-0003sv-4n for bug-gnu-emacs@gnu.org; Fri, 08 Aug 2014 05:20:07 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:55912) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XFgLD-0003sX-0h for bug-gnu-emacs@gnu.org; Fri, 08 Aug 2014 05:20:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1XFgLC-0005lK-If for bug-gnu-emacs@gnu.org; Fri, 08 Aug 2014 05:20:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 08 Aug 2014 09:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 18196 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 18196-submit@debbugs.gnu.org id=B18196.140748957822115 (code B ref 18196); Fri, 08 Aug 2014 09:20:02 +0000 Original-Received: (at 18196) by debbugs.gnu.org; 8 Aug 2014 09:19:38 +0000 Original-Received: from localhost ([127.0.0.1]:34622 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFgKn-0005kc-Sz for submit@debbugs.gnu.org; Fri, 08 Aug 2014 05:19:38 -0400 Original-Received: from mtaout24.012.net.il ([80.179.55.180]:36231) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1XFgKk-0005kM-Px for 18196@debbugs.gnu.org; Fri, 08 Aug 2014 05:19:35 -0400 Original-Received: from conversion-daemon.mtaout24.012.net.il by mtaout24.012.net.il (HyperSendmail v2007.08) id <0N9Z00M00DMK2L00@mtaout24.012.net.il> for 18196@debbugs.gnu.org; Fri, 08 Aug 2014 12:15:15 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout24.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0N9Z00KQSDPFNQ10@mtaout24.012.net.il>; Fri, 08 Aug 2014 12:15:15 +0300 (IDT) In-reply-to: <53E48D99.9040307@gmx.at> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:92298 Archived-At: > Date: Fri, 08 Aug 2014 10:43:05 +0200 > From: martin rudalics > CC: 18196@debbugs.gnu.org, "eliz@gnu.org" , > Mat Smiglarski > > OK. This was part one of our endeavour. We now have to discuss with > Eli on how to proceed. The current patch has three advantages: > > (1) It doesn't violate the uniform interface where all calls to > change_frame_size and adjust_frame_size use the window's text sizes > as arguments. > > (2) It doesn't require any change in window.c. > > (3) It has been tested. > > It has the following disadvantages: > > (1) Code changes in term.c and w32console.c from FRAME_LINES to > FRAME_TOTAL_LINES. > > (2) change_frame_size and adjust_frame_size must be explicitly called > with FRAME_MENU_BAR_LINES subtracted after calling get_tty_size. I don't mind these disadvantages, if what you describe is all of them. (I don't know enough about the code involved to have my own opinion on the disadvantages.) So, unless you prefer the other alternatives, I have no objections to your going ahead with this one. Thanks.