From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: srivasta@ieee.org, emacs-devel@gnu.org
Subject: Re: Trunk emacs infelicity with linum mode
Date: Sun, 07 Sep 2014 18:24:18 +0300 [thread overview]
Message-ID: <83ha0jcv31.fsf@gnu.org> (raw)
In-Reply-To: <540AED8A.9030000@gmx.at>
> Date: Sat, 06 Sep 2014 13:18:34 +0200
> From: martin rudalics <rudalics@gmx.at>
> Cc: emacs-devel@gnu.org
>
> From the frame creation code everything is normal AFAICT. The problem
> is with `linum--face-height' added on 2014-07-08 to the linum.el code:
>
> (defun linum--face-height (face)
> (aref (font-info (face-font face)) 2))
>
> ...
>
> (when (display-graphic-p)
> (setq width (ceiling
> ;; We'd really want to check the widths rather than the
> ;; heights, but it's a start.
> (/ (* width 1.0 (linum--face-height 'linum))
> (frame-char-height)))))
>
> If you take these out, the frame is created as usual.
Yes, but how does that help us resolve this problem? There's nothing
wrong in general with calling face-font, so linum-mode doesn't do
anything blatantly incorrect here. It's just that this function is
called "too early" in the frame creation process.
How about adding some simple flag that would avoid calling
window-configuration-change-hook when adjust_frame_size is called from
x-create-frame?
next prev parent reply other threads:[~2014-09-07 15:24 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-02 17:22 Trunk emacs infelicity with linum mode Manoj Srivastava
2014-09-02 18:03 ` Eli Zaretskii
2014-09-02 18:56 ` Manoj Srivastava
2014-09-02 19:11 ` Eli Zaretskii
2014-09-03 7:06 ` Manoj Srivastava
2014-09-03 15:50 ` Eli Zaretskii
2014-09-03 16:28 ` Manoj Srivastava
2014-09-04 15:29 ` Eli Zaretskii
2014-09-04 15:56 ` Stefan Monnier
2014-09-04 18:37 ` Eli Zaretskii
2014-09-04 20:25 ` Stefan Monnier
2014-09-05 6:58 ` Eli Zaretskii
2014-09-05 15:23 ` Stefan Monnier
2014-09-05 15:32 ` Eli Zaretskii
2014-09-05 16:23 ` Stefan Monnier
2014-09-05 17:49 ` Eli Zaretskii
2014-09-06 1:19 ` Manoj Srivastava
2014-09-06 7:43 ` Eli Zaretskii
2014-09-06 15:23 ` Manoj Srivastava
2014-09-06 20:27 ` Stefan Monnier
2014-09-07 5:07 ` Manoj Srivastava
2014-09-08 0:28 ` Stefan Monnier
2014-09-05 18:48 ` Manoj Srivastava
2014-09-05 19:53 ` Eli Zaretskii
2014-09-06 8:52 ` martin rudalics
2014-09-06 11:18 ` martin rudalics
2014-09-07 15:24 ` Eli Zaretskii [this message]
2014-09-07 18:03 ` martin rudalics
2014-09-07 19:28 ` Eli Zaretskii
2014-09-08 9:31 ` martin rudalics
2014-09-07 18:09 ` martin rudalics
2014-09-07 19:34 ` Eli Zaretskii
2014-09-08 9:32 ` martin rudalics
2014-09-09 13:13 ` Eli Zaretskii
2014-09-10 8:03 ` martin rudalics
2014-09-10 17:39 ` Eli Zaretskii
2014-09-10 19:02 ` martin rudalics
2014-09-10 19:15 ` Eli Zaretskii
2014-09-10 19:25 ` Eli Zaretskii
2014-09-11 9:26 ` martin rudalics
2014-09-11 15:14 ` Eli Zaretskii
2014-09-11 16:40 ` martin rudalics
2014-09-11 16:53 ` Eli Zaretskii
2014-09-11 17:59 ` martin rudalics
2014-09-11 18:09 ` martin rudalics
2014-09-03 12:37 ` Herbert J. Skuhra
2014-09-03 15:31 ` Manoj Srivastava
2015-01-04 18:09 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83ha0jcv31.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=rudalics@gmx.at \
--cc=srivasta@ieee.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.