From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#11732: 24.1; Microsoft IME Japanese input problem Date: Wed, 18 Feb 2015 17:17:04 +0200 Message-ID: <83h9uj5jwv.fsf@gnu.org> References: <87obohkxga.fsf@XAVIER-PC.i-did-not-set--mail-host-address--so-tickle-me> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1424272711 23845 80.91.229.3 (18 Feb 2015 15:18:31 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 18 Feb 2015 15:18:31 +0000 (UTC) Cc: 11732@debbugs.gnu.org To: Fujii Hironori Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Feb 18 16:18:21 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YO6OH-00073O-Bc for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Feb 2015 16:18:17 +0100 Original-Received: from localhost ([::1]:51449 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO6OG-0008AV-J4 for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Feb 2015 10:18:16 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58109) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO6O8-00082M-1Y for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2015 10:18:13 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1YO6O3-0007y2-2w for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2015 10:18:07 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1YO6O3-0007xy-0n for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2015 10:18:03 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1YO6O2-0007ai-Ex for bug-gnu-emacs@gnu.org; Wed, 18 Feb 2015 10:18:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Feb 2015 15:18:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 11732 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 11732-submit@debbugs.gnu.org id=B11732.142427264729116 (code B ref 11732); Wed, 18 Feb 2015 15:18:02 +0000 Original-Received: (at 11732) by debbugs.gnu.org; 18 Feb 2015 15:17:27 +0000 Original-Received: from localhost ([127.0.0.1]:47888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YO6NT-0007ZY-D3 for submit@debbugs.gnu.org; Wed, 18 Feb 2015 10:17:27 -0500 Original-Received: from mtaout25.012.net.il ([80.179.55.181]:50437) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YO6NQ-0007ZE-No for 11732@debbugs.gnu.org; Wed, 18 Feb 2015 10:17:25 -0500 Original-Received: from conversion-daemon.mtaout25.012.net.il by mtaout25.012.net.il (HyperSendmail v2007.08) id <0NJZ000003DPNI00@mtaout25.012.net.il> for 11732@debbugs.gnu.org; Wed, 18 Feb 2015 17:11:33 +0200 (IST) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by mtaout25.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NJZ00L3M3J84M50@mtaout25.012.net.il>; Wed, 18 Feb 2015 17:11:33 +0200 (IST) In-reply-to: X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:99541 Archived-At: > Date: Tue, 17 Feb 2015 19:26:41 +0900 > From: Fujii Hironori > > WM_IME_STARTCOMPOSITION should be passed to DefWindowProc. Thanks, but can you explain the details? I can understand why we should defer to DefWindowProc if we refrain from processing this message, for some reason. But this last part of your patch: > @@ -3318,17 +3318,17 @@ w32_wnd_proc (HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam) > > /* Punt if the window was deleted behind our back. */ > if (!BUFFERP (w->contents)) > - break; > + goto dflt; > > context = get_ime_context_fn (hwnd); > > if (!context) > - break; > + goto dflt; > > set_ime_composition_window_fn (context, &form); > release_ime_context_fn (hwnd, context); > } > - break; > + goto dflt; > > case WM_IME_ENDCOMPOSITION: > ignore_ime_char = 0; Passes the message to DefWindowProc even if we succeeded to handle WM_IME_STARTCOMPOSITION by calling ImmSetCompositionWindow. Why is that needed?