From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#15322: VC log buffer scrolls itself Date: Sun, 03 May 2015 17:34:07 +0300 Message-ID: <83h9rtu3vk.fsf@gnu.org> References: <861tiy5oa2.fsf@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1430663722 26827 80.91.229.3 (3 May 2015 14:35:22 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 3 May 2015 14:35:22 +0000 (UTC) Cc: rcopley@gmail.com, 15322@debbugs.gnu.org To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun May 03 16:35:14 2015 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1YouzA-000181-3D for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 May 2015 16:35:12 +0200 Original-Received: from localhost ([::1]:59457 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Youz9-0002gv-DK for geb-bug-gnu-emacs@m.gmane.org; Sun, 03 May 2015 10:35:11 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:57852) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Youz6-0002fc-An for bug-gnu-emacs@gnu.org; Sun, 03 May 2015 10:35:09 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Youz1-0005Xl-6V for bug-gnu-emacs@gnu.org; Sun, 03 May 2015 10:35:08 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:50852) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Youz1-0005XX-4Q for bug-gnu-emacs@gnu.org; Sun, 03 May 2015 10:35:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Youz0-00035U-Nj for bug-gnu-emacs@gnu.org; Sun, 03 May 2015 10:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 03 May 2015 14:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 15322 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 15322-submit@debbugs.gnu.org id=B15322.143066365611780 (code B ref 15322); Sun, 03 May 2015 14:35:02 +0000 Original-Received: (at 15322) by debbugs.gnu.org; 3 May 2015 14:34:16 +0000 Original-Received: from localhost ([127.0.0.1]:60826 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YouyF-00033w-S0 for submit@debbugs.gnu.org; Sun, 03 May 2015 10:34:16 -0400 Original-Received: from mtaout23.012.net.il ([80.179.55.175]:63309) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1YouyD-00033Z-QP for 15322@debbugs.gnu.org; Sun, 03 May 2015 10:34:15 -0400 Original-Received: from conversion-daemon.a-mtaout23.012.net.il by a-mtaout23.012.net.il (HyperSendmail v2007.08) id <0NNS00I002R90M00@a-mtaout23.012.net.il> for 15322@debbugs.gnu.org; Sun, 03 May 2015 17:34:07 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([87.69.4.28]) by a-mtaout23.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NNS00H5C34UXY60@a-mtaout23.012.net.il>; Sun, 03 May 2015 17:34:07 +0300 (IDT) In-reply-to: <861tiy5oa2.fsf@yandex.ru> X-012-Sender: halo1@inter.net.il X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:102400 Archived-At: > From: Dmitry Gutov > Date: Sun, 03 May 2015 06:32:37 +0300 > Cc: 15322@debbugs.gnu.org > > @@ -2263,8 +2264,10 @@ earlier revisions. Show up to LIMIT entries (non-nil means unlimited)." > (let ((inhibit-read-only t)) > (funcall setup-buttons-func backend files retval) > (shrink-window-if-larger-than-buffer) > - (funcall goto-location-func backend) > - (setq vc-sentinel-movepoint (point)) > + ;; Bug#15322 > + (when goto-location-func > + (funcall goto-location-func backend) > + (setq vc-sentinel-movepoint (point))) I don't think it's a good idea to have in the code comments that only mention the bug number, without also trying to explain the reason(s) for what the code does. If it's possible to write a clear and concise explanation, you don't even need to mention the bug number. If the reasons are so complex that they cannot be explained without repeating too much of the bug discussion, then there should be a summary and a pointer to the bug. Thanks.