From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: (pos-visible-in-window-p t nil t) returns wrong position/is suboptimally documented. Date: Wed, 30 Sep 2015 16:52:24 +0300 Message-ID: <83h9mcauav.fsf@gnu.org> References: <20150927104041.GA2401@acm.fritz.box> <8337y0f7es.fsf@gnu.org> <83twqcbcem.fsf@gnu.org> <20150930085611.GA6672@acm.fritz.box> <83lhbob6bs.fsf@gnu.org> <20150930102231.GB6672@acm.fritz.box> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1443682696 23074 80.91.229.3 (1 Oct 2015 06:58:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 1 Oct 2015 06:58:16 +0000 (UTC) Cc: emacs-devel@gnu.org To: Alan Mackenzie Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 01 08:58:07 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZhXod-00027g-FI for ged-emacs-devel@m.gmane.org; Thu, 01 Oct 2015 08:58:07 +0200 Original-Received: from localhost ([::1]:39107 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhXoc-00037l-Q9 for ged-emacs-devel@m.gmane.org; Thu, 01 Oct 2015 02:58:06 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:50765) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhHo9-0001JH-2N for emacs-devel@gnu.org; Wed, 30 Sep 2015 09:52:38 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZhHo4-0007Rc-UL for emacs-devel@gnu.org; Wed, 30 Sep 2015 09:52:32 -0400 Original-Received: from mtaout22.012.net.il ([80.179.55.172]:48717) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZhHo4-0007Qx-Lf for emacs-devel@gnu.org; Wed, 30 Sep 2015 09:52:28 -0400 Original-Received: from conversion-daemon.a-mtaout22.012.net.il by a-mtaout22.012.net.il (HyperSendmail v2007.08) id <0NVH00M00T4ZN000@a-mtaout22.012.net.il> for emacs-devel@gnu.org; Wed, 30 Sep 2015 16:52:27 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by a-mtaout22.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NVH00MEFT7EED50@a-mtaout22.012.net.il>; Wed, 30 Sep 2015 16:52:27 +0300 (IDT) In-reply-to: <20150930102231.GB6672@acm.fritz.box> X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 80.179.55.172 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:190520 Archived-At: > Date: Wed, 30 Sep 2015 10:22:31 +0000 > Cc: emacs-devel@gnu.org > From: Alan Mackenzie > > > > However 2: I think there's a bug in the functionality, too. If there is > > > o - a text buffer > > > o - with no terminating LF on its last line, and > > > o - that last line is above the window's last line > > > then (pos-visible-in-window t nil t) returns the coordinates of the last > > > lines's EOL. This is the case in both a Linux virtual terminal and an X > > > windows session. > > > It's not a bug. If you think it's important to mention this marginal > > use case, I can add that, too. > > OK, it's deliberate. It's a touch puzzling, though. I should grep the > elisp sources to find out what it's for. I do think it should be > mentioned in the doc, even if only for preventing somebody like me > raising a spurious bug report in the future. > > How about expressing the piece of documentation as: > > "If POSITION is `t', that means to check the position the first > visible position of the last visible screen line with text in > WINDOW; but if the end of the window's buffer is on the window, this > position is used instead." I already committed a change to describe that. The doc string now says If POS is t, it specifies either the first position displayed on the last visible screen line in WINDOW, or the end-of-buffer position, whichever comes first. and similar text is in the ELisp manual. OK?