From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] master 7836e42: Fix infloop in redisplay introduced by a recent change Date: Sat, 24 Oct 2015 17:18:52 +0300 Message-ID: <83h9lgwdrn.fsf@gnu.org> References: <20151023200751.16225.35237@vcs.savannah.gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1445696355 27793 80.91.229.3 (24 Oct 2015 14:19:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 24 Oct 2015 14:19:15 +0000 (UTC) Cc: emacs-devel@gnu.org To: Stefan Monnier Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Oct 24 16:19:06 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Zpzez-00036u-MA for ged-emacs-devel@m.gmane.org; Sat, 24 Oct 2015 16:19:05 +0200 Original-Received: from localhost ([::1]:44538 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zpzez-0000G7-1W for ged-emacs-devel@m.gmane.org; Sat, 24 Oct 2015 10:19:05 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43955) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zpzem-0000Fo-7z for emacs-devel@gnu.org; Sat, 24 Oct 2015 10:18:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Zpzej-0000YL-3z for emacs-devel@gnu.org; Sat, 24 Oct 2015 10:18:52 -0400 Original-Received: from mtaout29.012.net.il ([80.179.55.185]:46499) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Zpzei-0000YG-Rp for emacs-devel@gnu.org; Sat, 24 Oct 2015 10:18:49 -0400 Original-Received: from conversion-daemon.mtaout29.012.net.il by mtaout29.012.net.il (HyperSendmail v2007.08) id <0NWQ00B00A0C5W00@mtaout29.012.net.il> for emacs-devel@gnu.org; Sat, 24 Oct 2015 17:18:09 +0300 (IDT) Original-Received: from HOME-C4E4A596F7 ([84.94.185.246]) by mtaout29.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0NWQ002AWAE8A990@mtaout29.012.net.il>; Sat, 24 Oct 2015 17:18:09 +0300 (IDT) In-reply-to: X-012-Sender: halo1@inter.net.il X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 80.179.55.185 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:192544 Archived-At: > From: Stefan Monnier > Cc: Eli Zaretskii > Date: Sat, 24 Oct 2015 09:57:45 -0400 > > > * src/xdisp.c (redisplay_internal): Avoid inflooping when > > redisplaying the selected window sets the selected frame's > > redisplay flag. (Bug#21745) > > Thanks. Could you include in a comment a precise description of the > inf-loop? Done. > Reading the new code along with the above commit message I'm > left wondering exactly what was the problem: was a single redisplay > inf-looping (if so, where?), or was one redisplay immediately > causing another redisplay (if so, why do the subsequent redisplays > still set the selected frame's redisplay flag)? A single redisplay was inflooping. The frame's redisplay flag is reset only after a successful call to update_frame, so we haven't yet reach that point.