* Re: [Emacs-diffs] master 7836e42: Fix infloop in redisplay introduced by a recent change
[not found] ` <E1Zpicy-0004EM-0q@vcs.savannah.gnu.org>
@ 2015-10-24 13:57 ` Stefan Monnier
2015-10-24 14:18 ` Eli Zaretskii
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2015-10-24 13:57 UTC (permalink / raw)
To: emacs-devel; +Cc: Eli Zaretskii
> * src/xdisp.c (redisplay_internal): Avoid inflooping when
> redisplaying the selected window sets the selected frame's
> redisplay flag. (Bug#21745)
Thanks. Could you include in a comment a precise description of the
inf-loop? Reading the new code along with the above commit message I'm
left wondering exactly what was the problem: was a single redisplay
inf-looping (if so, where?), or was one redisplay immediately
causing another redisplay (if so, why do the subsequent redisplays
still set the selected frame's redisplay flag)?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 7836e42: Fix infloop in redisplay introduced by a recent change
2015-10-24 13:57 ` [Emacs-diffs] master 7836e42: Fix infloop in redisplay introduced by a recent change Stefan Monnier
@ 2015-10-24 14:18 ` Eli Zaretskii
2015-10-24 21:16 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: Eli Zaretskii @ 2015-10-24 14:18 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Sat, 24 Oct 2015 09:57:45 -0400
>
> > * src/xdisp.c (redisplay_internal): Avoid inflooping when
> > redisplaying the selected window sets the selected frame's
> > redisplay flag. (Bug#21745)
>
> Thanks. Could you include in a comment a precise description of the
> inf-loop?
Done.
> Reading the new code along with the above commit message I'm
> left wondering exactly what was the problem: was a single redisplay
> inf-looping (if so, where?), or was one redisplay immediately
> causing another redisplay (if so, why do the subsequent redisplays
> still set the selected frame's redisplay flag)?
A single redisplay was inflooping.
The frame's redisplay flag is reset only after a successful call to
update_frame, so we haven't yet reach that point.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Emacs-diffs] master 7836e42: Fix infloop in redisplay introduced by a recent change
2015-10-24 14:18 ` Eli Zaretskii
@ 2015-10-24 21:16 ` Stefan Monnier
0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2015-10-24 21:16 UTC (permalink / raw)
To: Eli Zaretskii; +Cc: emacs-devel
>> Thanks. Could you include in a comment a precise description of the
>> inf-loop?
> Done.
Great, thanks.
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-10-24 21:16 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20151023200751.16225.35237@vcs.savannah.gnu.org>
[not found] ` <E1Zpicy-0004EM-0q@vcs.savannah.gnu.org>
2015-10-24 13:57 ` [Emacs-diffs] master 7836e42: Fix infloop in redisplay introduced by a recent change Stefan Monnier
2015-10-24 14:18 ` Eli Zaretskii
2015-10-24 21:16 ` Stefan Monnier
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.