From: Eli Zaretskii <eliz@gnu.org>
To: Stefan Monnier <monnier@IRO.UMontreal.CA>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 7836e42: Fix infloop in redisplay introduced by a recent change
Date: Sat, 24 Oct 2015 17:18:52 +0300 [thread overview]
Message-ID: <83h9lgwdrn.fsf@gnu.org> (raw)
In-Reply-To: <jwv1tck5q8m.fsf-monnier+emacsdiffs@gnu.org>
> From: Stefan Monnier <monnier@IRO.UMontreal.CA>
> Cc: Eli Zaretskii <eliz@gnu.org>
> Date: Sat, 24 Oct 2015 09:57:45 -0400
>
> > * src/xdisp.c (redisplay_internal): Avoid inflooping when
> > redisplaying the selected window sets the selected frame's
> > redisplay flag. (Bug#21745)
>
> Thanks. Could you include in a comment a precise description of the
> inf-loop?
Done.
> Reading the new code along with the above commit message I'm
> left wondering exactly what was the problem: was a single redisplay
> inf-looping (if so, where?), or was one redisplay immediately
> causing another redisplay (if so, why do the subsequent redisplays
> still set the selected frame's redisplay flag)?
A single redisplay was inflooping.
The frame's redisplay flag is reset only after a successful call to
update_frame, so we haven't yet reach that point.
next prev parent reply other threads:[~2015-10-24 14:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20151023200751.16225.35237@vcs.savannah.gnu.org>
[not found] ` <E1Zpicy-0004EM-0q@vcs.savannah.gnu.org>
2015-10-24 13:57 ` [Emacs-diffs] master 7836e42: Fix infloop in redisplay introduced by a recent change Stefan Monnier
2015-10-24 14:18 ` Eli Zaretskii [this message]
2015-10-24 21:16 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h9lgwdrn.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=monnier@IRO.UMontreal.CA \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.