all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: martin rudalics <rudalics@gmx.at>
Cc: 21895@debbugs.gnu.org, eric.hanchrow@gmail.com
Subject: bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895)
Date: Fri, 13 Nov 2015 10:23:17 +0200	[thread overview]
Message-ID: <83h9kqgvey.fsf@gnu.org> (raw)
In-Reply-To: <56459995.90008@gmx.at>

> Date: Fri, 13 Nov 2015 09:04:37 +0100
> From: martin rudalics <rudalics@gmx.at>
> 
>  > +(defun fringes-p ()
>  > +  "Return t if fringe-columns is bound, and either (fringe-columns 'left)
>  > or (fringe-columns 'right) returns nonzero."
>  > +  (and (fboundp 'fringe-columns)
>  > +       (or (not (zerop (fringe-columns 'right)))
>  > +           (not (zerop (fringe-columns 'left))))))
>  > +
> 
> This is wrong when ‘fringe-columns’ is unbound and a fringe is present.

Why would that happen?  fringe.el is preloaded when GUI frames are
supported, and if not, there are no fringes.  What am I missing?

> The right solution is to
> 
> (require 'fringe)
> 
> in ‘shr-mode’ as you proposed earlier.

What if the user doesn't want fringes in her sessions?





  reply	other threads:[~2015-11-13  8:23 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-13  0:06 bug#21895: 25.0.50; eww: Lisp error: (void-function fringe-columns) Eric Hanchrow
2015-11-13  0:17 ` bug#21895: easy workaround Eric Hanchrow
2015-11-13  1:29   ` bug#21895: [PATCH] shr: don't invoke unbound function (Bug#21895) Eric Hanchrow
2015-11-13  1:35     ` Eric Hanchrow
2015-11-13  1:48       ` John Wiegley
2015-11-13  3:16     ` Glenn Morris
2015-11-13  3:24       ` Glenn Morris
2015-11-13  9:24       ` Eli Zaretskii
2015-11-13  8:04     ` martin rudalics
2015-11-13  8:23       ` Eli Zaretskii [this message]
2015-11-13 10:01         ` martin rudalics

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h9kqgvey.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=21895@debbugs.gnu.org \
    --cc=eric.hanchrow@gmail.com \
    --cc=rudalics@gmx.at \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.