From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Update of pcase docs for the elisp manual Date: Fri, 29 Jan 2016 17:37:13 +0200 Message-ID: <83h9hwxuqe.fsf@gnu.org> References: <87d1stznc6.fsf@web.de> <83io2k5yvg.fsf@gnu.org> <838u3c18w3.fsf@gnu.org> <83y4bcytk6.fsf@gnu.org> <83zivoyeh9.fsf@gnu.org> <83powkxy7s.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1454082060 29502 80.91.229.3 (29 Jan 2016 15:41:00 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 29 Jan 2016 15:41:00 +0000 (UTC) Cc: emacs-devel@gnu.org To: Andy Moreton Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jan 29 16:40:57 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1aPB9r-0005HP-Sp for ged-emacs-devel@m.gmane.org; Fri, 29 Jan 2016 16:40:24 +0100 Original-Received: from localhost ([::1]:34843 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPB9r-0008CF-Ak for ged-emacs-devel@m.gmane.org; Fri, 29 Jan 2016 10:40:23 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43384) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPB7A-0002tY-7b for emacs-devel@gnu.org; Fri, 29 Jan 2016 10:37:37 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1aPB76-0007BF-UJ for emacs-devel@gnu.org; Fri, 29 Jan 2016 10:37:36 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:43674) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1aPB76-0007BB-Rr; Fri, 29 Jan 2016 10:37:32 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4100 helo=HOME-C4E4A596F7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1aPB76-0006G4-6k; Fri, 29 Jan 2016 10:37:32 -0500 In-reply-to: (message from Andy Moreton on Fri, 29 Jan 2016 15:14:17 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:198998 Archived-At: > From: Andy Moreton > Date: Fri, 29 Jan 2016 15:14:17 +0000 > > Fair enough. Please consider starting a new paragraph though: > > "The ‘cond’ form lets you choose between alternatives using predicate > conditions that compare values of expressions against specific values > known and written in advance. However, sometimes it is useful to select > alternatives based on more general conditions that distinguish between > broad classes of values. > > The ‘pcase’ macro allows you to choose between alternatives based on > matching the value of an expression against a series of patterns. A > pattern can be a literal value (for comparisons to literal values you’d > use ‘cond’), or it can be a more general description of the expected > structure of the expression’s value." Fine with me, thanks. Feel free to commit. > >> However the doc strings are inconsistent with the manual: > >> pcase: (PATTERN CODE...) > >> cond: (CONDITION BODY...) > >> > >> It would be better to use consistent terms. > > > > Blame those who wrote the doc strings ;-) > > I sought improvement, not blame :-) Feel free to improve the doc strings in that direction, and thanks.