From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Use of strftime in movemail.ec Date: Sat, 05 Mar 2016 13:01:59 +0200 Message-ID: <83h9glxk60.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1457175744 1434 80.91.229.3 (5 Mar 2016 11:02:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 5 Mar 2016 11:02:24 +0000 (UTC) Cc: emacs-devel@gnu.org To: Paul Eggert Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 05 12:02:17 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ac9yS-0005kg-9x for ged-emacs-devel@m.gmane.org; Sat, 05 Mar 2016 12:02:16 +0100 Original-Received: from localhost ([::1]:45920 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ac9yR-0002Jz-Qp for ged-emacs-devel@m.gmane.org; Sat, 05 Mar 2016 06:02:15 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54519) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ac9yF-0002Ja-M2 for emacs-devel@gnu.org; Sat, 05 Mar 2016 06:02:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ac9yC-0001HQ-GS for emacs-devel@gnu.org; Sat, 05 Mar 2016 06:02:03 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:54959) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ac9yC-0001HM-D1; Sat, 05 Mar 2016 06:02:00 -0500 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1221 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1ac9yB-0000G4-IP; Sat, 05 Mar 2016 06:01:59 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:200940 Archived-At: movemail.c uses strftime as follows: char fromline[100]; if (! strftime (fromline, sizeof fromline, "From movemail %a %b %e %T %Y\n", ltime)) The %e and %T formats are not supported by the MS-Windows runtime version of strftime, and the result is that movemail produces mbox files where Rmail doesn't see any valid email messages. I believe these format specifiers were used under the assumption that Gnulib's strftime will be used on systems that don't support the full functionality. However, Gnulib's strftime.c defines a function my_strftime, which is renamed by config.h as nstrftime, and I don't see anywhere any machinery to force movemail call nstrftime. Am I missing something? For now, I pushed a change to emacs-25 (commit 7923112) to use only portable specifiers there. But if a simple and safe change can be made that would cause nstrftime be called by movemail (without any adverse effects on Emacs itself), let's do that instead.