all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Paul Eggert <eggert@cs.ucla.edu>
Cc: kzhr@d1.dion.ne.jp, 23600@debbugs.gnu.org
Subject: bug#23600: 25.1.50; encode-time returns wrong result
Date: Sat, 04 Jun 2016 18:51:50 +0300	[thread overview]
Message-ID: <83h9d9uf3d.fsf@gnu.org> (raw)
In-Reply-To: <574E9AA6.1070606@cs.ucla.edu> (message from Paul Eggert on Wed,  1 Jun 2016 01:19:50 -0700)

> Cc: 23600@debbugs.gnu.org, Eli Zaretskii <eliz@gnu.org>
> From: Paul Eggert <eggert@cs.ucla.edu>
> Date: Wed, 1 Jun 2016 01:19:50 -0700
> 
> +  if (strncmp (str, "TZ=<", 4) == 0)
> +    {
> +      /* MS-Windows does not support POSIX.1-2001 angle-bracket TZ
> +	 abbreviation syntax.  Convert to POSIX.1-1988 syntax if possible,
> +	 and to the undocumented placeholder "ZZZ" otherwise.  */
> +      bool supported_abbr = true;
> +      for (char *p = str + 4; *p; p++)
> +	{
> +	  if (('0' <= *p && *p <= '9') || *p == '-' || *p == '+')
> +	    supported_abbr = false;
> +	  else if (*p == '>')
> +	    {
> +	      ptrdiff_t abbrlen;
> +	      if (supported_abbr)
> +		{
> +		  abbrlen = p - (str + 4);
> +		  memmove (str + 3, str + 4, abbrlen);
> +		}
> +	      else
> +		{
> +		  abbrlen = 3;
> +		  memset (str + 3, 'Z', abbrlen);
> +		}
> +	      memmove (str + 3 + abbrlen, p + 1, strlen (p));
> +	      break;
> +	    }

Do callers of putenv expect the argument to be destroyed?

Thanks.





  parent reply	other threads:[~2016-06-04 15:51 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-22 22:10 bug#23600: 25.1.50; encode-time returns wrong result Kazuhiro Ito
2016-06-01  8:19 ` Paul Eggert
2016-06-02  1:54   ` Kazuhiro Ito
2016-06-02  6:38     ` Paul Eggert
2016-06-05 11:08       ` Kazuhiro Ito
2016-06-12 10:45       ` Kazuhiro Ito
2016-06-13 21:54         ` Paul Eggert
2016-06-14 14:05           ` Kazuhiro Ito
2016-06-14 14:40             ` Paul Eggert
2016-06-04 15:51   ` Eli Zaretskii [this message]
2016-06-04 17:15     ` Paul Eggert
2016-06-04 17:37       ` Eli Zaretskii
2016-06-04 22:18         ` Paul Eggert
2016-06-05  2:47           ` Eli Zaretskii
2016-06-05 15:20             ` Eli Zaretskii
2016-06-06  1:48               ` Paul Eggert

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h9d9uf3d.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=23600@debbugs.gnu.org \
    --cc=eggert@cs.ucla.edu \
    --cc=kzhr@d1.dion.ne.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.