From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#23695: 25.0.94; todo-mode breaks minibuffer-complete-word Date: Fri, 10 Jun 2016 13:18:48 +0300 Message-ID: <83h9d1pcs7.fsf@gnu.org> References: <87y46km1s9.fsf@gmx.net> <8760thxuj5.fsf@gmx.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1465554694 2729 80.91.229.3 (10 Jun 2016 10:31:34 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 10 Jun 2016 10:31:34 +0000 (UTC) Cc: 23695@debbugs.gnu.org To: Stephen Berman Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Fri Jun 10 12:31:23 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bBJij-0000lh-61 for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Jun 2016 12:31:21 +0200 Original-Received: from localhost ([::1]:39601 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBJii-0003BH-Aw for geb-bug-gnu-emacs@m.gmane.org; Fri, 10 Jun 2016 06:31:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:40629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBJWp-0001B7-Pr for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2016 06:19:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBJWo-0003IR-Er for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2016 06:19:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:51079) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBJWo-0003IM-Bv for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2016 06:19:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bBJWo-0002W0-5B for bug-gnu-emacs@gnu.org; Fri, 10 Jun 2016 06:19:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 10 Jun 2016 10:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 23695 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 23695-submit@debbugs.gnu.org id=B23695.14655538989611 (code B ref 23695); Fri, 10 Jun 2016 10:19:02 +0000 Original-Received: (at 23695) by debbugs.gnu.org; 10 Jun 2016 10:18:18 +0000 Original-Received: from localhost ([127.0.0.1]:35183 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBJW5-0002Ux-T8 for submit@debbugs.gnu.org; Fri, 10 Jun 2016 06:18:18 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:49352) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bBJW5-0002Ul-6I for 23695@debbugs.gnu.org; Fri, 10 Jun 2016 06:18:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bBJVv-0002ra-40 for 23695@debbugs.gnu.org; Fri, 10 Jun 2016 06:18:12 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:55176) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bBJVv-0002rJ-0I; Fri, 10 Jun 2016 06:18:07 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:4457 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bBJVt-0006DN-0X; Fri, 10 Jun 2016 06:18:05 -0400 In-reply-to: <8760thxuj5.fsf@gmx.net> (message from Stephen Berman on Fri, 10 Jun 2016 11:28:14 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:119377 Archived-At: > From: Stephen Berman > Date: Fri, 10 Jun 2016 11:28:14 +0200 > > On Sun, 05 Jun 2016 11:18:46 +0200 Stephen Berman wrote: > > > 0. emacs -Q > > 1. Sanity check: Typing e.g. `C-h f url- SPC' should pop up a > > *Completions* buffer showing functions beginning with "url-", since > > SPC in the minibuffer is bound to minibuffer-complete-word. > > 2. C-g to exit the minibuffer, then, if you have no files made by > > todo-mode (i.e. no directory ~/.emacs.d/todo), type `M-x todo-show > > RET RET RET RET RET' (accepting defaults) to create a todo file with > > a category and an entry. > > 3. Type `q' to quit todo-mode (optional) and redo step 1. > > => Upon typing SPC this time, instead of getting the *Completions* > > buffer, a space is inserted in the minibuffer after "url-". > > > > If at step 2 you already have one or more todo-files, then invoking a > > number of todo-mode commands, e.g. `j' to jump to another category or > > `C a' to add a new category, will likewise globally change the effect of > > all subsequent uses of SPC in the minibuffer. > > > > The patch below fixes this. I request approval to push this fix to > > emacs-25, since without it, todo-mode-specific behavior changes the > > minibuffer behavior in rest of Emacs. Also, the fix is certainly safe, > > since it replaces naively implemented functionality by canonical code to > > temporarily change a minibuffer key binding. > > Ping! Any objections to pushing this fix to emacs-25? We've lived with this for the last 2 years, how come it's so urgent now?