From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: Dead or unused face handling code Date: Thu, 07 Jul 2016 18:15:19 +0300 Message-ID: <83h9c1lbso.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1467904558 2043 80.91.229.3 (7 Jul 2016 15:15:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 7 Jul 2016 15:15:58 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Antipov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Jul 07 17:15:53 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bLB1m-0000QT-QV for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2016 17:15:46 +0200 Original-Received: from localhost ([::1]:40546 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLB1m-0004V5-1L for ged-emacs-devel@m.gmane.org; Thu, 07 Jul 2016 11:15:46 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:58718) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLB1g-0004Pi-6u for emacs-devel@gnu.org; Thu, 07 Jul 2016 11:15:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLB1a-0004pS-A3 for emacs-devel@gnu.org; Thu, 07 Jul 2016 11:15:39 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:56090) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLB1a-0004p5-6e; Thu, 07 Jul 2016 11:15:34 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1831 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bLB1W-00056K-HM; Thu, 07 Jul 2016 11:15:31 -0400 In-reply-to: (message from Dmitry Antipov on Thu, 7 Jul 2016 09:57:03 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:205333 Archived-At: > Cc: Eli Zaretskii > From: Dmitry Antipov > Date: Thu, 7 Jul 2016 09:57:03 +0300 > > I've found a few dummy/unused bits around face_at_xxx functions, and running > with these patches (which see) for a few days without any problems. But since > redisplay is very tricky, I don't feel brave enough to install them without > having some feedback first... I'm sorry, but I don't want to make these changes, for a couple of reasons: . Changes like these are similar to whitespace changes, so they are generally okay as part of a larger changeset that fixes a real problem or adds a feature. But when done alone, they are just nuisance: they make forensics harder for no good reason. They also risk introducing bugs, and we don't really have a test suite for the display engine to be sure we didn't screw up anything. . The functionality you are proposing to delete is useful, even if currently largely unused. We are extremely short on people who can resurrect this code if it is ever needed in the future; I'm not sure how many people here even know how to begin writing such code. (Looking up deleted code in Git history is not trivial, many people simply don't know how to do that, and won't try in the first place, because they won't know such code ever existed.) So by deleting these seemingly unneeded bits, we will forever lose non-trivial baggage that no one on board, except maybe yours truly, can restore. Thanks.