From: Eli Zaretskii <eliz@gnu.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: Dead or unused face handling code
Date: Thu, 07 Jul 2016 18:15:19 +0300 [thread overview]
Message-ID: <83h9c1lbso.fsf@gnu.org> (raw)
In-Reply-To: <efdcd4ff-ab87-b46d-0471-931c84561fe7@yandex.ru> (message from Dmitry Antipov on Thu, 7 Jul 2016 09:57:03 +0300)
> Cc: Eli Zaretskii <eliz@gnu.org>
> From: Dmitry Antipov <dmantipov@yandex.ru>
> Date: Thu, 7 Jul 2016 09:57:03 +0300
>
> I've found a few dummy/unused bits around face_at_xxx functions, and running
> with these patches (which see) for a few days without any problems. But since
> redisplay is very tricky, I don't feel brave enough to install them without
> having some feedback first...
I'm sorry, but I don't want to make these changes, for a couple of
reasons:
. Changes like these are similar to whitespace changes, so they are
generally okay as part of a larger changeset that fixes a real
problem or adds a feature. But when done alone, they are just
nuisance: they make forensics harder for no good reason. They also
risk introducing bugs, and we don't really have a test suite for
the display engine to be sure we didn't screw up anything.
. The functionality you are proposing to delete is useful, even if
currently largely unused. We are extremely short on people who can
resurrect this code if it is ever needed in the future; I'm not
sure how many people here even know how to begin writing such code.
(Looking up deleted code in Git history is not trivial, many people
simply don't know how to do that, and won't try in the first place,
because they won't know such code ever existed.) So by deleting
these seemingly unneeded bits, we will forever lose non-trivial
baggage that no one on board, except maybe yours truly, can
restore.
Thanks.
next prev parent reply other threads:[~2016-07-07 15:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 6:57 Dead or unused face handling code Dmitry Antipov
2016-07-07 15:15 ` Eli Zaretskii [this message]
2016-07-07 15:47 ` Display test suite Clément Pit--Claudel
2016-07-07 16:29 ` Eli Zaretskii
2016-07-07 19:40 ` Clément Pit--Claudel
2016-07-08 13:40 ` Richard Stallman
2016-07-08 13:44 ` Kaushal Modi
2016-07-08 16:19 ` Clément Pit--Claudel
2016-07-08 13:50 ` Andreas Schwab
2016-07-08 15:19 ` raman
2016-07-07 17:47 ` Dead or unused face handling code Dmitry Antipov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h9c1lbso.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=dmantipov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.