From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#10980: GNU bugs information: logs for bug#10980 Date: Sat, 09 Jul 2016 13:57:33 +0300 Message-ID: <83h9bzgjtu.fsf@gnu.org> References: <83twh3r5vr.fsf@gnu.org> <83d1na7jtx.fsf@gnu.org> <83k2hi54ml.fsf@gnu.org> <83fus55l0l.fsf@gnu.org> <83bn2kvxen.fsf@gnu.org> <838txovwk7.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: plane.gmane.org X-Trace: ger.gmane.org 1468061968 29021 80.91.229.3 (9 Jul 2016 10:59:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 9 Jul 2016 10:59:28 +0000 (UTC) Cc: bo.johansson@lsn.se, 10980@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 09 12:59:17 2016 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1bLpyc-0000At-Jv for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jul 2016 12:59:14 +0200 Original-Received: from localhost ([::1]:49795 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLpyb-0002pe-Qn for geb-bug-gnu-emacs@m.gmane.org; Sat, 09 Jul 2016 06:59:13 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:42742) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLpyU-0002pN-W4 for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2016 06:59:08 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLpyQ-0000fO-SD for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2016 06:59:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59154) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLpyQ-0000fK-OX for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2016 06:59:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1bLpyQ-0002iP-Ha for bug-gnu-emacs@gnu.org; Sat, 09 Jul 2016 06:59:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 09 Jul 2016 10:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10980 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 10980-submit@debbugs.gnu.org id=B10980.146806189110375 (code B ref 10980); Sat, 09 Jul 2016 10:59:02 +0000 Original-Received: (at 10980) by debbugs.gnu.org; 9 Jul 2016 10:58:11 +0000 Original-Received: from localhost ([127.0.0.1]:43258 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLpxb-0002hH-HU for submit@debbugs.gnu.org; Sat, 09 Jul 2016 06:58:11 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:51640) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLpxZ-0002h2-UE for 10980@debbugs.gnu.org; Sat, 09 Jul 2016 06:58:10 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bLpxR-0000VU-HN for 10980@debbugs.gnu.org; Sat, 09 Jul 2016 06:58:04 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:38302) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bLpx9-0000U5-HD; Sat, 09 Jul 2016 06:57:43 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1517 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_128_CBC_SHA1:128) (Exim 4.82) (envelope-from ) id 1bLpx7-00071J-10; Sat, 09 Jul 2016 06:57:41 -0400 In-reply-to: (message from Noam Postavsky on Wed, 29 Jun 2016 19:02:25 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:120669 Archived-At: > From: Noam Postavsky > Date: Wed, 29 Jun 2016 19:02:25 -0400 > Cc: 10980@debbugs.gnu.org, bo.johansson@lsn.se > > Ah, I think I missed the idea that changing Vprocess_environment would > still affect Emacs' environment (technically, what Emacs thinks its > environment is, which has the same effect). Patch attached. Thanks, please push to master, after fixing the following minor issues: > * src/emacs.c (main): For WINDOWSNT platform, move init_environment > calls after the set_initial_environment call. This prevents Emacs' > modifications to the environment from contaminating Vprocess_environment > and Vinitial_environment (Bug #10980). Code changes in fragments guarded by preprocessor conditionals should be formatted like this: * src/emacs.c (main) [WINDOWSNT]: Move init_environment calls after ... > * src/callproc.c (getenv_internal): Consult Emacs' internal environment > in as a fallback to Vprocess_environment on WINDOWSNT platforms. Same here. > + *valuelen = strlen(tmpval); ^^^^^^^ Please leave a single blank between a function's name and the following opening parenthesis. > + /* Initialize environment from registry settings. Make sure to do > + this only after calling set_initial_environment so that > + Vinitial_environment and Vprocess_environment will contain only > + variables from the parent process without modifications from > + Emacs. */ Please leave 2 blanks between the last period of the comment text and the comment terminator "*/". Bonus points for adding a test for this issue.