From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#27597: [PATCH] fix warnings in src/xdisp.c Date: Sat, 08 Jul 2017 11:19:32 +0300 Message-ID: <83h8ynl4rv.fsf@gnu.org> References: Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1499502017 12383 195.159.176.226 (8 Jul 2017 08:20:17 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 8 Jul 2017 08:20:17 +0000 (UTC) Cc: 27597-done@debbugs.gnu.org To: Alexander Kuleshov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Jul 08 10:20:11 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTkyH-0002jz-9o for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Jul 2017 10:20:09 +0200 Original-Received: from localhost ([::1]:60284 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTkyK-0008Dh-Tc for geb-bug-gnu-emacs@m.gmane.org; Sat, 08 Jul 2017 04:20:12 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48650) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTkyB-0008DQ-MZ for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 04:20:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTkyA-00088R-SK for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 04:20:03 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:54599) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dTkyA-00088H-P2 for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 04:20:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dTkyA-0004W6-Ks for bug-gnu-emacs@gnu.org; Sat, 08 Jul 2017 04:20:02 -0400 Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Sat, 08 Jul 2017 08:20:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 27597 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Mail-Followup-To: 27597@debbugs.gnu.org, eliz@gnu.org, kuleshovmail@gmail.com Original-Received: via spool by 27597-done@debbugs.gnu.org id=D27597.149950199717341 (code D ref 27597); Sat, 08 Jul 2017 08:20:02 +0000 Original-Received: (at 27597-done) by debbugs.gnu.org; 8 Jul 2017 08:19:57 +0000 Original-Received: from localhost ([127.0.0.1]:57275 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTky4-0004Vd-Ng for submit@debbugs.gnu.org; Sat, 08 Jul 2017 04:19:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57643) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dTky2-0004VO-Si for 27597-done@debbugs.gnu.org; Sat, 08 Jul 2017 04:19:55 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dTkxq-00082n-VJ for 27597-done@debbugs.gnu.org; Sat, 08 Jul 2017 04:19:49 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:37471) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dTkxq-00082h-RY; Sat, 08 Jul 2017 04:19:42 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:1610 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dTkxq-0002hW-60; Sat, 08 Jul 2017 04:19:42 -0400 In-reply-to: (message from Alexander Kuleshov on Thu, 6 Jul 2017 17:47:03 +0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:134327 Archived-At: > From: Alexander Kuleshov > Date: Thu, 6 Jul 2017 17:47:03 +0600 > > here is simple fix for following warnings: > > xdisp.c: In function ‘Fdump_glyph_matrix’: > xdisp.c:19320:20: error: format ‘%lld’ expects argument of type ‘long > long int’, but argument 3 has type ‘ptrdiff_t {aka long int}’ > [-Werror=format=] > fprintf (stderr, "PT = %"pI"d, BEGV = %"pI"d. ZV = %"pI"d\n", > > from src/xdisp.c Thanks, pushed to master. In the future, please provide a commit log message that is according to our coding standards: . mention the names of functions in which you make changes . start sentences with a capital letter . mention the bug number Here's the log message I used in this case: * src/xdisp.c (dump_glyph, dump_glyph_row, Fdump_glyph_matrix): Use pD directives for ptrdiff_t values instead of pI, to avoid compilation warnings on 64-bit hosts. (Bug#27597)