From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] elpa/packages/sokoban/sokoban.el Date: Sun, 09 Jul 2017 17:52:41 +0300 Message-ID: <83h8ylk6h2.fsf@gnu.org> References: <87bmotlokk.fsf@deyke2> <83o9stk87j.fsf@gnu.org> <877ezhllwi.fsf@deyke2> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1499611981 5356 195.159.176.226 (9 Jul 2017 14:53:01 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 9 Jul 2017 14:53:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dieter Deyke Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Jul 09 16:52:54 2017 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1dUDZt-0000yS-H0 for ged-emacs-devel@m.gmane.org; Sun, 09 Jul 2017 16:52:53 +0200 Original-Received: from localhost ([::1]:36409 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUDZy-0006yX-Ud for ged-emacs-devel@m.gmane.org; Sun, 09 Jul 2017 10:52:58 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:49308) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUDZt-0006yP-8G for emacs-devel@gnu.org; Sun, 09 Jul 2017 10:52:53 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dUDZp-0007iC-Cl for emacs-devel@gnu.org; Sun, 09 Jul 2017 10:52:53 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:53645) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dUDZp-0007i7-9r; Sun, 09 Jul 2017 10:52:49 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:3142 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1dUDZo-0002Rt-KX; Sun, 09 Jul 2017 10:52:49 -0400 In-reply-to: <877ezhllwi.fsf@deyke2> (message from Dieter Deyke on Sun, 09 Jul 2017 16:34:05 +0200) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 2001:4830:134:3::e X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:216369 Archived-At: > From: Dieter Deyke > Cc: emacs-devel@gnu.org > Date: Sun, 09 Jul 2017 16:34:05 +0200 > > > Please show the commit log message you intend to use. > > > > Also, does this warrant a NEWS entry? > > > > Thanks. > > The commit log message I was about to use is > > change player and block color if on target In general, commit log messages should follow the format of ChangeLog files as described in CONTRIBUTE. But maybe this is not required for ELPA? (I thought sokoban.el was bundled with Emacs, sorry for not looking closer.) > About a NEWS entry, I do not know. Does ELPA have a separate NEWS file? No, I don't think so. Again, I missed the fact that sokoban.el is an ELPA package. Thanks.