From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#25025: python-shell-calculate-command is wrong Date: Wed, 16 Aug 2017 19:57:30 +0300 Message-ID: <83h8x7fo1x.fsf@gnu.org> References: <83polk3qow.fsf@gnu.org> <83inra13r3.fsf@gnu.org> <8337ic29y0.fsf@gnu.org> <87r35wj4b8.fsf@users.sourceforge.net> <83zikkzytf.fsf@gnu.org> <8737i9iz28.fsf@users.sourceforge.net> <1949fc46-fd26-dddb-86b2-ab3478587271@gmail.com> <87wpflhgsf.fsf@users.sourceforge.net> <83a8chq7x6.fsf@gnu.org> <83d1hbpobp.fsf@gnu.org> <87h96ngmmq.fsf@users.sourceforge.net> <83k2biokad.fsf@gnu.org> <87pol1ekko.fsf@users.sourceforge.net> <87inhnzs54.fsf@users.sourceforge.net> <83r2wbfus5.fsf@gnu.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1502902694 24882 195.159.176.226 (16 Aug 2017 16:58:14 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 16 Aug 2017 16:58:14 +0000 (UTC) Cc: 25025@debbugs.gnu.org, clement.pit@gmail.com To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Aug 16 18:58:08 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di1ds-0005vB-4E for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Aug 2017 18:58:04 +0200 Original-Received: from localhost ([::1]:60408 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1di1dy-0001xl-OJ for geb-bug-gnu-emacs@m.gmane.org; Wed, 16 Aug 2017 12:58:10 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44513) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1di1dt-0001xF-0B for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 12:58:05 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1di1dq-0001VP-51 for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 12:58:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:60975) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1di1dq-0001VK-0q for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 12:58:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1di1dp-00018h-Pn for bug-gnu-emacs@gnu.org; Wed, 16 Aug 2017 12:58:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 16 Aug 2017 16:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 25025 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed confirmed Original-Received: via spool by 25025-submit@debbugs.gnu.org id=B25025.15029026784370 (code B ref 25025); Wed, 16 Aug 2017 16:58:01 +0000 Original-Received: (at 25025) by debbugs.gnu.org; 16 Aug 2017 16:57:58 +0000 Original-Received: from localhost ([127.0.0.1]:41423 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di1dl-00018Q-QE for submit@debbugs.gnu.org; Wed, 16 Aug 2017 12:57:57 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:53491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1di1dk-00018D-88 for 25025@debbugs.gnu.org; Wed, 16 Aug 2017 12:57:56 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1di1da-0001KF-5I for 25025@debbugs.gnu.org; Wed, 16 Aug 2017 12:57:51 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:59382) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1di1da-0001K9-1d; Wed, 16 Aug 2017 12:57:46 -0400 Original-Received: from 84.94.185.246.cable.012.net.il ([84.94.185.246]:2872 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1di1dZ-0003Jn-Fg; Wed, 16 Aug 2017 12:57:45 -0400 In-reply-to: (message from Noam Postavsky on Wed, 16 Aug 2017 12:50:25 -0400) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:135829 Archived-At: > From: Noam Postavsky > Date: Wed, 16 Aug 2017 12:50:25 -0400 > Cc: Clément Pit--Claudel , > 25025@debbugs.gnu.org > > (ert-deftest python-shell-calculate-command-1 () > "Check the command to execute is calculated correctly. > Using `python-shell-interpreter' and > `python-shell-interpreter-args'." > (skip-unless (executable-find python-tests-shell-interpreter)) > (let ((python-shell-interpreter (executable-find > python-tests-shell-interpreter)) > (python-shell-interpreter-args "-B")) > (should (string= > (format "%s %s" > (shell-quote-argument python-shell-interpreter) > python-shell-interpreter-args) > (python-shell-calculate-command))))) > > This is the old version of python-shell-calculate-command: > > (defun python-shell-calculate-command () > "Calculate the string used to execute the inferior Python process." > (format "%s %s" > (shell-quote-argument python-shell-interpreter) > python-shell-interpreter-args)) > > As you can see, the test just repeats the function body and checks for > equality. I see, thanks. So I guess all it (maybe) tests is that python-shell-interpreter and what executable-find returns are identical? Is that something that could somehow fail and would be useful to verify? If not, I agree to removing the test.