From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28855: 26.0.90; display-line-numbers-mode does not respect (line|wrap)-prefix '(space :align-to N) text property Date: Wed, 18 Oct 2017 19:47:31 +0300 Message-ID: <83h8uwe730.fsf@gnu.org> References: <1508125091.3713406.1139815176.12F59A69@webmail.messagingengine.com> <83po9nf58h.fsf@gnu.org> <3fdce54f-f704-66df-75db-843dbd98ec50@yandex.ru> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1508345370 11203 195.159.176.226 (18 Oct 2017 16:49:30 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 18 Oct 2017 16:49:30 +0000 (UTC) Cc: 28855@debbugs.gnu.org, Stefan Monnier , John Wiegley To: Dmitry Gutov , martin rudalics Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed Oct 18 18:49:26 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4rWk-0008Ou-OA for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Oct 2017 18:49:06 +0200 Original-Received: from localhost ([::1]:45603 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4rWs-0006lK-5g for geb-bug-gnu-emacs@m.gmane.org; Wed, 18 Oct 2017 12:49:14 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:46396) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4rWk-0006kR-Tv for bug-gnu-emacs@gnu.org; Wed, 18 Oct 2017 12:49:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4rWg-0003sh-CS for bug-gnu-emacs@gnu.org; Wed, 18 Oct 2017 12:49:07 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:39847) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e4rWg-0003sZ-86 for bug-gnu-emacs@gnu.org; Wed, 18 Oct 2017 12:49:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e4rWg-0008Gf-1R for bug-gnu-emacs@gnu.org; Wed, 18 Oct 2017 12:49:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 18 Oct 2017 16:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28855 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 28855-submit@debbugs.gnu.org id=B28855.150834528431699 (code B ref 28855); Wed, 18 Oct 2017 16:49:01 +0000 Original-Received: (at 28855) by debbugs.gnu.org; 18 Oct 2017 16:48:04 +0000 Original-Received: from localhost ([127.0.0.1]:48528 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4rVk-0008FC-Dc for submit@debbugs.gnu.org; Wed, 18 Oct 2017 12:48:04 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:55174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e4rVi-0008Eh-Ok for 28855@debbugs.gnu.org; Wed, 18 Oct 2017 12:48:03 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e4rVc-0003KW-EC for 28855@debbugs.gnu.org; Wed, 18 Oct 2017 12:47:57 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:44297) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e4rVS-0002y8-0w; Wed, 18 Oct 2017 12:47:46 -0400 Original-Received: from [176.228.60.248] (port=3776 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e4rVR-0006Ye-Bi; Wed, 18 Oct 2017 12:47:45 -0400 In-reply-to: <3fdce54f-f704-66df-75db-843dbd98ec50@yandex.ru> (message from Dmitry Gutov on Wed, 18 Oct 2017 12:29:08 +0300) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138676 Archived-At: > Cc: 28855@debbugs.gnu.org > From: Dmitry Gutov > Date: Wed, 18 Oct 2017 12:29:08 +0300 > > FTR, I'd have preferred for the line numbers to be considered outside of > the window edge, together with fringes and margins. And I still don't > see any downside to it (except it might be harder to implement). Well, "harder to implement" is very relevant here ;-) Also, "outside of the window edge" has implications besides text layout, and I trust Martin's judgment (which happens to match mine) that we should try letting those sleeping dogs lie. In any case, this opinion of yours probably means that having :align-to automatically update its offsets to account for the line numbers is in the direction you wanted Emacs to go, albeit not all the way, right? I mean, it does make Emacs behave as if line numbers were not part of the text area in this case. > As it is now, third-party code has to adapt instead, by handling the > line numbers specially. Yes. But this is nothing new, it happens with almost every display-related feature. > > But maybe :align-to should be an exception, when > > used to align buffer text (as opposed to header-line or mode-line)? > > Though I'm bothered whether some users of :align-to may not want this > > automatic offset. :align-to is a very popular feature; does anyone > > know or imagine why a Lisp program would NOT like such an offset? > > > > What do people think? Dmitry, what about company-mode popups, for > > example? > > Not sure. What about them? We don't use align-to in the popups (though > we could, for space-only offsets, now that I've read about this spec; > not sure if the change will be worth it, performance or memory-wise). > > And as for align-to's used in the buffer text, we probably don't support > them very well, but the proposed change shouldn't make it any worse, I > think. OK, thanks. Martin, any comments or thoughts about this, before I go out and make the code changes to implement this? Anybody else? Stefan? John? TIA