From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#28803: [PATCH] Fixed compiler warnings for advised functions. Date: Sun, 22 Oct 2017 17:04:47 +0300 Message-ID: <83h8urb7nk.fsf@gnu.org> References: <87infi9t0p.fsf@users.sourceforge.net> <874lr19trw.fsf@users.sourceforge.net> <87zi8kcbzw.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: blaine.gmane.org 1508681128 8402 195.159.176.226 (22 Oct 2017 14:05:28 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 22 Oct 2017 14:05:28 +0000 (UTC) Cc: 28803@debbugs.gnu.org, npostavs@users.sourceforge.net To: John Williams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Oct 22 16:05:21 2017 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6GsG-0007nY-3O for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Oct 2017 16:05:08 +0200 Original-Received: from localhost ([::1]:32973 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6GsN-0007Od-9O for geb-bug-gnu-emacs@m.gmane.org; Sun, 22 Oct 2017 10:05:15 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:41413) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6GsD-0007OI-Lf for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2017 10:05:06 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e6GsA-00047U-HB for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2017 10:05:05 -0400 Original-Received: from debbugs.gnu.org ([208.118.235.43]:47308) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1e6GsA-00047L-Df for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2017 10:05:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1e6GsA-00062X-37 for bug-gnu-emacs@gnu.org; Sun, 22 Oct 2017 10:05:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 22 Oct 2017 14:05:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 28803 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: confirmed fixed patch Original-Received: via spool by 28803-submit@debbugs.gnu.org id=B28803.150868110123215 (code B ref 28803); Sun, 22 Oct 2017 14:05:02 +0000 Original-Received: (at 28803) by debbugs.gnu.org; 22 Oct 2017 14:05:01 +0000 Original-Received: from localhost ([127.0.0.1]:55989 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6Gs9-00062G-7A for submit@debbugs.gnu.org; Sun, 22 Oct 2017 10:05:01 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:50402) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1e6Gs8-000623-5U for 28803@debbugs.gnu.org; Sun, 22 Oct 2017 10:05:00 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1e6Gs0-00042i-0n for 28803@debbugs.gnu.org; Sun, 22 Oct 2017 10:04:55 -0400 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:39677) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1e6Grz-00042e-TV; Sun, 22 Oct 2017 10:04:51 -0400 Original-Received: from [176.228.60.248] (port=1257 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1e6Grz-0004jo-9i; Sun, 22 Oct 2017 10:04:51 -0400 In-reply-to: (message from John Williams on Sat, 21 Oct 2017 19:23:35 -0700) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:138849 Archived-At: > From: John Williams > Date: Sat, 21 Oct 2017 19:23:35 -0700 > Cc: 28803@debbugs.gnu.org > > Hooray, my first official contribution to Emacs! Now I have code—not much, but some—in both Emacs and > Vim, which I have to think is pretty rare. Welcome on board, and thanks for your contribution. > BTW, is posting to this list really the best way to send patches? You are not posting to a list, you are sending to our issue tracker. Having your patches sent to a mailing list is just one of the interfaces provided by the tracker; there are others (like an Emacs interface, see the debbugs package in ELPA. > At my job, all changes go through a code > review tool similar to Gerrit, with code uploaded using a command analogous to "git push", so sending a patch > as an email attachment feels clumsy and anachronistic. For large changesets, we recommend a scratch branch.