From: Eli Zaretskii <eliz@gnu.org>
To: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
Cc: 29374-done@debbugs.gnu.org
Subject: bug#29374: patch for lisp/pixel-scroll
Date: Fri, 01 Dec 2017 10:58:12 +0200 [thread overview]
Message-ID: <83h8ta3jvf.fsf@gnu.org> (raw)
In-Reply-To: <20171122.080817.1272652886334028034.tkk@misasa.okayama-u.ac.jp> (message from Tak Kunihiro on Wed, 22 Nov 2017 08:08:17 +0900 (JST))
> Date: Wed, 22 Nov 2017 08:08:17 +0900 (JST)
> Cc: 29374@debbugs.gnu.org, tkk@misasa.okayama-u.ac.jp
> From: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
>
> >> Date: Tue, 21 Nov 2017 13:35:07 +0900 (JST)
> >> From: Tak Kunihiro <tkk@misasa.okayama-u.ac.jp>
> >> Cc: tkk@misasa.okayama-u.ac.jp
> >>
> >> I'm sending a patch for lisp/pixel-scroll.el.
> >>
> >> This patch fixes movement of cursor to stay away from the top of the
> >> line and the end of the line on a screen.
> >
> > Thanks, but please tell more about the problem, and perhaps show a
> > recipe to reproduce it.
>
> First of all, expression of my previous message was not correct.
> Let me rephrase as below.
>
> This patch fixes movement of cursor to stay away from the top and
> the bottom of a screen.
>
> Before fix, sudden scope-jump happened on certain cases. Let's
> consider a case with cursor is located at the bottom and about to
> scroll down (move scope up).
>
> There is a condition where
> bob is shown on the top of screen
> and window-vscroll is non-zero.
>
> On this condition, (scroll-up 1) would be called without
> (vertical-motion -1). As a consequence screen jumps.
>
> After the fix, cursor will be moved by vertical-motion before calling
> scroll-down or pixel-scroll-pixel-down.
Thanks, I pushed your changes.
prev parent reply other threads:[~2017-12-01 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-21 4:35 bug#29374: patch for lisp/pixel-scroll Tak Kunihiro
2017-11-21 15:41 ` Eli Zaretskii
2017-11-21 23:08 ` Tak Kunihiro
2017-12-01 8:58 ` Eli Zaretskii [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h8ta3jvf.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=29374-done@debbugs.gnu.org \
--cc=tkk@misasa.okayama-u.ac.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.