From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30342: 25.3; xfont_draw in xfont.c does the same thing in both branches of an if statement Date: Sun, 04 Feb 2018 18:17:58 +0200 Message-ID: <83h8qwafux.fsf@gnu.org> References: <87zi4ph7zp.fsf@erebor.i-did-not-set--mail-host-address--so-tickle-me> <87d11lfqlq.fsf@users.sourceforge.net> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1517761055 23038 195.159.176.226 (4 Feb 2018 16:17:35 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sun, 4 Feb 2018 16:17:35 +0000 (UTC) Cc: db48x@db48x.net, 30342@debbugs.gnu.org To: Noam Postavsky Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Feb 04 17:17:30 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiMyY-0004JF-Dy for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Feb 2018 17:17:06 +0100 Original-Received: from localhost ([::1]:39049 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiN0Z-0001C3-F7 for geb-bug-gnu-emacs@m.gmane.org; Sun, 04 Feb 2018 11:19:11 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:43598) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiN0U-0001Bh-3u for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 11:19:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eiN0Q-0008LQ-4i for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 11:19:06 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:49377) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eiN0Q-0008L3-1v for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 11:19:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1eiN0P-0001ie-SB for bug-gnu-emacs@gnu.org; Sun, 04 Feb 2018 11:19:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 04 Feb 2018 16:19:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30342 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30342-submit@debbugs.gnu.org id=B30342.15177611006560 (code B ref 30342); Sun, 04 Feb 2018 16:19:01 +0000 Original-Received: (at 30342) by debbugs.gnu.org; 4 Feb 2018 16:18:20 +0000 Original-Received: from localhost ([127.0.0.1]:57274 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiMzk-0001hk-Ax for submit@debbugs.gnu.org; Sun, 04 Feb 2018 11:18:20 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52249) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eiMzi-0001hV-E4 for 30342@debbugs.gnu.org; Sun, 04 Feb 2018 11:18:18 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eiMzZ-0007L6-4J for 30342@debbugs.gnu.org; Sun, 04 Feb 2018 11:18:13 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:58721) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eiMzZ-0007Kn-1K; Sun, 04 Feb 2018 11:18:09 -0500 Original-Received: from [176.228.60.248] (port=2915 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1eiMzY-0000ic-Fb; Sun, 04 Feb 2018 11:18:08 -0500 In-reply-to: <87d11lfqlq.fsf@users.sourceforge.net> (message from Noam Postavsky on Sat, 03 Feb 2018 21:14:41 -0500) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:142890 Archived-At: > From: Noam Postavsky > Date: Sat, 03 Feb 2018 21:14:41 -0500 > Cc: 30342@debbugs.gnu.org > > Daniel Brooks writes: > > > I happened to be looking at this function and noticed that both sides of > > the with_background condition do exactly the same thing; I'm sure it > > gradually got so. > > > > http://git.savannah.gnu.org/cgit/emacs.git/tree/src/xfont.c#n1046 > > They don't do *exactly* the same thing, one calls XDrawString and the > other XDrawImageString. Right. So I think there's no problem here, and this bug can be closed.