all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Eli Zaretskii <eliz@gnu.org>
To: Noam Postavsky <npostavs@users.sourceforge.net>
Cc: db48x@db48x.net, 30342@debbugs.gnu.org
Subject: bug#30342: 25.3; xfont_draw in xfont.c does the same thing in both branches of an if statement
Date: Sun, 04 Feb 2018 18:17:58 +0200	[thread overview]
Message-ID: <83h8qwafux.fsf@gnu.org> (raw)
In-Reply-To: <87d11lfqlq.fsf@users.sourceforge.net> (message from Noam Postavsky on Sat, 03 Feb 2018 21:14:41 -0500)

> From: Noam Postavsky <npostavs@users.sourceforge.net>
> Date: Sat, 03 Feb 2018 21:14:41 -0500
> Cc: 30342@debbugs.gnu.org
> 
> Daniel Brooks <db48x@db48x.net> writes:
> 
> > I happened to be looking at this function and noticed that both sides of
> > the with_background condition do exactly the same thing; I'm sure it
> > gradually got so.
> >
> > http://git.savannah.gnu.org/cgit/emacs.git/tree/src/xfont.c#n1046
> 
> They don't do *exactly* the same thing, one calls XDrawString and the
> other XDrawImageString.

Right.  So I think there's no problem here, and this bug can be
closed.





      reply	other threads:[~2018-02-04 16:17 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-04  1:13 bug#30342: 25.3; xfont_draw in xfont.c does the same thing in both branches of an if statement Daniel Brooks
2018-02-04  2:14 ` Noam Postavsky
2018-02-04 16:17   ` Eli Zaretskii [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=83h8qwafux.fsf@gnu.org \
    --to=eliz@gnu.org \
    --cc=30342@debbugs.gnu.org \
    --cc=db48x@db48x.net \
    --cc=npostavs@users.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.