From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#30699: 26.0.91; buffer contents flicker on macOS frames when frames are resized Date: Sat, 10 Mar 2018 10:30:27 +0200 Message-ID: <83h8pouycc.fsf@gnu.org> References: <83tvtus8rc.fsf@gnu.org> <20180305192331.GA26656@breton.holly.idiocy.org> <83muzms3i6.fsf@gnu.org> <20180306225502.GA30546@breton.holly.idiocy.org> <83a7vjre52.fsf@gnu.org> <20180307202603.GA31176@breton.holly.idiocy.org> <83r2ounzty.fsf@gnu.org> <20180309120952.GA45581@breton.holly.idiocy.org> <837eqlwf1i.fsf@gnu.org> <20180309232415.GB51893@breton.holly.idiocy.org> <20180310002555.GA54231@breton.holly.idiocy.org> Reply-To: Eli Zaretskii NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1520671393 4997 195.159.176.226 (10 Mar 2018 08:43:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Sat, 10 Mar 2018 08:43:13 +0000 (UTC) Cc: 30699@debbugs.gnu.org, aaronjensen@gmail.com To: Alan Third Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Mar 10 09:43:08 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1eua5r-0001Bd-Kv for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2018 09:43:07 +0100 Original-Received: from localhost ([::1]:49733 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eua7u-0007Mu-IW for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Mar 2018 03:45:14 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54502) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euZuD-0005Dz-R7 for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 03:31:06 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euZuA-0001nR-NB for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 03:31:05 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:45163) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1euZuA-0001nN-Iq for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 03:31:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1euZuA-00061k-DP for bug-gnu-emacs@gnu.org; Sat, 10 Mar 2018 03:31:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Mar 2018 08:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 30699 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 30699-submit@debbugs.gnu.org id=B30699.152067064023132 (code B ref 30699); Sat, 10 Mar 2018 08:31:02 +0000 Original-Received: (at 30699) by debbugs.gnu.org; 10 Mar 2018 08:30:40 +0000 Original-Received: from localhost ([127.0.0.1]:53060 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euZtn-000612-R0 for submit@debbugs.gnu.org; Sat, 10 Mar 2018 03:30:40 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:35187) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1euZtm-00060q-BC for 30699@debbugs.gnu.org; Sat, 10 Mar 2018 03:30:38 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1euZtg-0001VI-8J for 30699@debbugs.gnu.org; Sat, 10 Mar 2018 03:30:33 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:52327) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1euZtc-0001Oi-A2; Sat, 10 Mar 2018 03:30:28 -0500 Original-Received: from [176.228.60.248] (port=2520 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1euZtb-0002Pq-9i; Sat, 10 Mar 2018 03:30:27 -0500 In-reply-to: <20180310002555.GA54231@breton.holly.idiocy.org> (message from Alan Third on Sat, 10 Mar 2018 00:25:55 +0000) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:144095 Archived-At: > Date: Sat, 10 Mar 2018 00:25:55 +0000 > From: Alan Third > Cc: 30699@debbugs.gnu.org, aaronjensen@gmail.com > > diff --git a/src/nsterm.m b/src/nsterm.m > index 1919c6defa..b4ec384aaf 100644 > --- a/src/nsterm.m > +++ b/src/nsterm.m > @@ -288,6 +288,7 @@ - (NSColor *)colorUsingDefaultColorSpace > static BOOL ns_fake_keydown = NO; > #ifdef NS_IMPL_COCOA > static BOOL ns_menu_bar_is_hidden = NO; > +static int disable_screen_updates_count = 0; Doesn't making this static mean potential trouble if redisplay is run from a non-main thread? > diff --git a/src/xdisp.c b/src/xdisp.c > index 9170d6b777..d4fdb44b32 100644 > --- a/src/xdisp.c > +++ b/src/xdisp.c > @@ -14599,6 +14599,9 @@ redisplay_internal (void) > end_of_redisplay: > #ifdef HAVE_NS > ns_set_doc_edited (); > +#ifdef NS_IMPL_COCOA > + ns_enable_screen_updates (); > +#endif > #endif Can x_set_window_size be called only from redisplay_internal? If not, doesn't this risk leaving the updates disabled, if x_set_window_size is called from some other place? Also, redisplay_internal has a few early returns which don't go through end_of_redisplay -- are you sure they can never happen in this situation? For example, what if popup_activated returns non-zero? Finally, this code needs comments that explain why this is done. Thanks.