From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33275: 27.0.50; Image cache pruning Date: Mon, 05 Nov 2018 21:28:32 +0200 Message-ID: <83h8gvcoin.fsf@gnu.org> References: <83va5bcxxu.fsf@gnu.org> <83sh0fcx2r.fsf@gnu.org> <83o9b3cu4f.fsf@gnu.org> <83muqncry4.fsf@gnu.org> <83k1lrcqza.fsf@gnu.org> NNTP-Posting-Host: blaine.gmane.org X-Trace: blaine.gmane.org 1541446033 21573 195.159.176.226 (5 Nov 2018 19:27:13 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 5 Nov 2018 19:27:13 +0000 (UTC) Cc: 33275@debbugs.gnu.org To: Lars Ingebrigtsen Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Nov 05 20:27:09 2018 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJkWi-0005SN-16 for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Nov 2018 20:27:08 +0100 Original-Received: from localhost ([::1]:37276 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJkYo-0002sh-AA for geb-bug-gnu-emacs@m.gmane.org; Mon, 05 Nov 2018 14:29:18 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59425) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJkYe-0002sJ-0D for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2018 14:29:12 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJkYY-0007Ra-Ub for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2018 14:29:07 -0500 Original-Received: from debbugs.gnu.org ([208.118.235.43]:59614) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gJkYY-0007Qg-QF for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2018 14:29:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gJkYY-0000wQ-Im for bug-gnu-emacs@gnu.org; Mon, 05 Nov 2018 14:29:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 05 Nov 2018 19:29:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33275 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 33275-submit@debbugs.gnu.org id=B33275.15414461343604 (code B ref 33275); Mon, 05 Nov 2018 19:29:02 +0000 Original-Received: (at 33275) by debbugs.gnu.org; 5 Nov 2018 19:28:54 +0000 Original-Received: from localhost ([127.0.0.1]:35639 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJkYM-0000w1-V5 for submit@debbugs.gnu.org; Mon, 05 Nov 2018 14:28:54 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:49725) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gJkYI-0000vl-05 for 33275@debbugs.gnu.org; Mon, 05 Nov 2018 14:28:49 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gJkY7-0006Og-Mt for 33275@debbugs.gnu.org; Mon, 05 Nov 2018 14:28:40 -0500 Original-Received: from fencepost.gnu.org ([2001:4830:134:3::e]:34108) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gJkY7-0006Ob-JF; Mon, 05 Nov 2018 14:28:35 -0500 Original-Received: from [176.228.60.248] (port=2388 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gJkY7-0004Dn-6x; Mon, 05 Nov 2018 14:28:35 -0500 In-reply-to: (message from Lars Ingebrigtsen on Mon, 05 Nov 2018 20:13:27 +0100) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 208.118.235.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:152079 Archived-At: > From: Lars Ingebrigtsen > Cc: 33275@debbugs.gnu.org > Date: Mon, 05 Nov 2018 20:13:27 +0100 > > If I understand you correctly, you seem to favour introducing code that > will break code that's working today (if you insert an image into a > buffer today in a memory-pressure situation, that won't signal an error > today) instead of tweaking a non-documented ad-hoc caching strategy (by > taking the image cache size into consideration), or fixing the caching > (by using weak hash tables), and I'm not quite sure why. Because your use case is not important enough to change image caching strategy that works well for many years. > `image-size' didn't use to cache images, but was introduced as an > optimisation. And that optimization had a reason, right? Btw, why doesn't xmalloc return NULL in your case before invoking the OOM killer? Is that expected behavior on GNU/Linux systems?