From: Eli Zaretskii <eliz@gnu.org>
To: Glenn Morris <rgm@gnu.org>
Cc: 33344@debbugs.gnu.org, trent2@web.de
Subject: bug#33344: 26.1; doc-view bounding-box recognition doesn't work on path names with spaces
Date: Tue, 13 Nov 2018 21:24:55 +0200 [thread overview]
Message-ID: <83h8gk93w8.fsf@gnu.org> (raw)
In-Reply-To: <2pmuqcalt3.fsf@fencepost.gnu.org> (message from Glenn Morris on Tue, 13 Nov 2018 13:12:40 -0500)
> From: Glenn Morris <rgm@gnu.org>
> Cc: trent2@web.de, 33344@debbugs.gnu.org
> Date: Tue, 13 Nov 2018 13:12:40 -0500
>
> > And I wonder how many more subtle incompatibilities will such a change
> > cause. All that because we need to run a single string through
> > shell-quote-argument (and not just enclose it in double quotes)? Is
> > it really worth it?
>
> External processes should not be called through a shell unless they
> really need that, and I see no evidence for that here.
I don't disagree, but that's not the point. The point is that this
code was written to use the shell, and it works. Turning it upside
down because it failed to quote a single argument risks introducing
bugs and backward incompatibilities for what IMO is a very small gain.
next prev parent reply other threads:[~2018-11-13 19:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-11 11:36 bug#33344: 26.1; doc-view bounding-box recognition doesn't work on path names with spaces Robert Spillner
2018-11-12 21:36 ` Glenn Morris
2018-11-13 17:08 ` Eli Zaretskii
2018-11-13 18:12 ` Glenn Morris
2018-11-13 19:24 ` Eli Zaretskii [this message]
2018-11-14 18:14 ` Glenn Morris
2018-11-14 19:29 ` Eli Zaretskii
2018-11-22 23:47 ` Robert Spillner
2020-08-26 12:38 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h8gk93w8.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=33344@debbugs.gnu.org \
--cc=rgm@gnu.org \
--cc=trent2@web.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.