From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Eli Zaretskii Newsgroups: gmane.emacs.bugs Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Date: Sat, 23 Feb 2019 19:01:46 +0200 Message-ID: <83h8cuphfp.fsf@gnu.org> References: <87d0pcfkjq.fsf@gmail.com> <87mumpgl0v.fsf@gmail.com> <83bm34fccz.fsf@gnu.org> <87mumncy6v.fsf@gmail.com> <83zhqmq44v.fsf@gnu.org> <87va1ask2c.fsf@gmail.com> Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="242667"; mail-complaints-to="usenet@blaine.gmane.org" Cc: 33975@debbugs.gnu.org To: Alex Branham Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Feb 23 18:04:10 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1gxaie-0010y1-86 for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Feb 2019 18:04:08 +0100 Original-Received: from localhost ([127.0.0.1]:40626 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxaid-0003pI-1c for geb-bug-gnu-emacs@m.gmane.org; Sat, 23 Feb 2019 12:04:07 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:56524) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxagd-0002i0-He for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2019 12:02:04 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gxagc-0003Eq-Ou for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2019 12:02:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36034) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gxagc-0003Dy-Hz for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2019 12:02:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1gxagc-0001nJ-5m for bug-gnu-emacs@gnu.org; Sat, 23 Feb 2019 12:02:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 23 Feb 2019 17:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 33975 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 33975-submit@debbugs.gnu.org id=B33975.15509413116881 (code B ref 33975); Sat, 23 Feb 2019 17:02:02 +0000 Original-Received: (at 33975) by debbugs.gnu.org; 23 Feb 2019 17:01:51 +0000 Original-Received: from localhost ([127.0.0.1]:49578 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxagR-0001mv-Jk for submit@debbugs.gnu.org; Sat, 23 Feb 2019 12:01:51 -0500 Original-Received: from eggs.gnu.org ([209.51.188.92]:41998) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gxagP-0001mj-Ir for 33975@debbugs.gnu.org; Sat, 23 Feb 2019 12:01:49 -0500 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]:52229) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gxagK-0002pX-6o; Sat, 23 Feb 2019 12:01:44 -0500 Original-Received: from [176.228.60.248] (port=2208 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1gxagJ-0002aB-GY; Sat, 23 Feb 2019 12:01:44 -0500 In-reply-to: <87va1ask2c.fsf@gmail.com> (message from Alex Branham on Sat, 23 Feb 2019 07:36:43 -0600) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:155699 Archived-At: > From: Alex Branham > Cc: 33975@debbugs.gnu.org > Date: Sat, 23 Feb 2019 07:36:43 -0600 > > > Then shouldn't the change be inside comint-skip-input instead? I > > mean, the same problem will happen also in all other callers of > > comint-skip-input, no? > > Probably, yes. Changed in the attached patch. > > > (I'm not sure I understand why that function inserts the description > > of this-command-keys -- is that to insert "C-c C-c" into the buffer? > > This is not in the doc string, perhaps we should add that.) > > The attached patch adds it. WDYT? > > (defun comint-skip-input () > "Skip all pending input, from last stuff output by interpreter to point. > -This means mark it as if it had been sent as input, without sending it." > +This means mark it as if it had been sent as input, without > +sending it. The command keys used to trigger this command are > +inserted into the buffer." "this command" is inaccurate here, as comint-skip-input is not a command. I'd say "the command which called this function" instead. Other than that, LGTM. Thanks.