From: Eli Zaretskii <eliz@gnu.org>
To: Alex Branham <alex.branham@gmail.com>
Cc: 33975@debbugs.gnu.org
Subject: bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob
Date: Sat, 23 Feb 2019 19:01:46 +0200 [thread overview]
Message-ID: <83h8cuphfp.fsf@gnu.org> (raw)
In-Reply-To: <87va1ask2c.fsf@gmail.com> (message from Alex Branham on Sat, 23 Feb 2019 07:36:43 -0600)
> From: Alex Branham <alex.branham@gmail.com>
> Cc: 33975@debbugs.gnu.org
> Date: Sat, 23 Feb 2019 07:36:43 -0600
>
> > Then shouldn't the change be inside comint-skip-input instead? I
> > mean, the same problem will happen also in all other callers of
> > comint-skip-input, no?
>
> Probably, yes. Changed in the attached patch.
>
> > (I'm not sure I understand why that function inserts the description
> > of this-command-keys -- is that to insert "C-c C-c" into the buffer?
> > This is not in the doc string, perhaps we should add that.)
>
> The attached patch adds it. WDYT?
>
> (defun comint-skip-input ()
> "Skip all pending input, from last stuff output by interpreter to point.
> -This means mark it as if it had been sent as input, without sending it."
> +This means mark it as if it had been sent as input, without
> +sending it. The command keys used to trigger this command are
> +inserted into the buffer."
"this command" is inaccurate here, as comint-skip-input is not a
command. I'd say "the command which called this function" instead.
Other than that, LGTM. Thanks.
next prev parent reply other threads:[~2019-02-23 17:01 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-04 16:35 bug#33975: [PATCH] inhibit read-only text properties in comint-interrupt-subjob Alex Branham
2019-02-21 16:32 ` Alex Branham
2019-02-22 8:37 ` Eli Zaretskii
2019-02-22 21:26 ` Alex Branham
2019-02-23 8:51 ` Eli Zaretskii
2019-02-23 13:36 ` Alex Branham
2019-02-23 17:01 ` Eli Zaretskii [this message]
2019-02-24 14:47 ` Alex Branham
2019-02-25 1:11 ` Alex Branham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=83h8cuphfp.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=33975@debbugs.gnu.org \
--cc=alex.branham@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.